Skip to content

init: Do not select DEBUG_KERNEL by default

Sinan Kaya linux-mips linuxppc-dev lkml netdev netfilter-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest5 patches 4 repliesIn review
  2. v45 patches 6 repliesSuperseded
  3. v31 patch 8 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v21 patch10 repliesSuperseded
v11 patch10 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5init: Introduce DEBUG_MISC optionlib/Kconfig.debug+9 -00 replies
2/5powerpc: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISCarch/powerpc/kernel/sysfs.c+4 -40 replies
3/5mips: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISCarch/mips/kernel/setup.c+1 -10 replies
4/5xtensa: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISCarch/xtensa/include/asm/irqflags.h arch/xtensa/kernel/smp.c+2 -21 reply
5/5net: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISCnet/netfilter/core.c+1 -10 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJosh TriplettFlorian WestphalMax FilippovKees Cook
SeriesR-b
1/5R-b
2/5R-b
3/5R-b
4/5R-b A-b
5/5R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/5] init: Do not select DEBUG_KERNEL by default

CONFIG_DEBUG_KERNEL has been designed to just enable Kconfig options. Kernel code generatoin should not depend on CONFIG_DEBUG_KERNEL.

Proposed alternative plan: let's add a new symbol, something like DEBUG_MISC ("Miscellaneous debug code that should be under a more specific debug option but isn't"), make it depend on DEBUG_KERNEL and be "default DEBUG_KERNEL" but allow itself to be turned off, and then mechanically change the small handful of "#ifdef CONFIG_DEBUG_KERNEL" to "#ifdef CONFIG_DEBUG_MISC".

Diff from v4:
- collect reviewed-by
- collect acked-by
- fix nit on 1/5

Sinan Kaya (5):
init: Introduce DEBUG_MISC option
powerpc: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC
mips: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC
xtensa: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC
net: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC

 arch/mips/kernel/setup.c           | 2 +-
 arch/powerpc/kernel/sysfs.c        | 8 ++++----
 arch/xtensa/include/asm/irqflags.h | 2 +-
 arch/xtensa/kernel/smp.c           | 2 +-
 lib/Kconfig.debug                  | 9 +++++++++
 net/netfilter/core.c               | 2 +-
 6 files changed, 17 insertions(+), 8 deletions(-)
Signature · 1 line
2.21.0