Skip to content

nvme: Check size of command structures

Keith Busch linux-nvme 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] nvme: Check size of command structures
Quoted 3 lines · Minwoo Im

Many command structures have been added in linux/nvme.h wihtout BUILD_BUG_ON() check. It also needs to be assured to avoid unintended growth of structures.

We're already protected from accidentally increasing a command size since 'struct nvme_command' unionizes them all. Its size would be the largest command in the union and we do check it's 64 bytes. Unintended shrinkage, though, that would require individual command type checks, so okay.