Skip to content

Enable Tegra PCIe root port features

Manikanta Maddireddy linux-devicetree linux-pci linux-tegra 6 versions – Applied

Status from this message: Applied to for-5.3/arm64/dt, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest27 patches 21 repliesApplied
  2. v527 patches 3 repliesSuperseded
  3. v428 patches 43 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v329 patches3 repliesSuperseded
v228 patches35 repliesSuperseded
v130 patches75 repliesSuperseded

Changes in v6 from the cover letter

- Patch [V4, 20/27]: Replaced pcie_pme_disable_msi() with no_msi quirk

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/27soc/tegra: pmc: Export tegra_powergate_power_on()drivers/soc/tegra/pmc.c+1 -00 replies
2/27PCI: tegra: Handle failure cases in tegra_pcie_power_on()drivers/pci/controller/pci-tegra.c+21 -50 replies
3/27PCI: tegra: Rearrange Tegra PCIe driver functionsdrivers/pci/controller/pci-tegra.c+30 -400 replies
4/27PCI: tegra: Mask AFI_INTR in runtime suspenddrivers/pci/controller/pci-tegra.c+15 -02 replies
5/27PCI: tegra: Fix PCIe host power up sequencedrivers/pci/controller/pci-tegra.c+30 -220 replies
6/27PCI: tegra: Add PCIe Gen2 link speed supportdrivers/pci/controller/pci-tegra.c+64 -03 replies
7/27PCI: tegra: Advertise PCIe Advanced Error Reporting (AER) capabilitydrivers/pci/controller/pci-tegra.c+15 -02 replies
8/27PCI: tegra: Program UPHY electrical settings for Tegra210drivers/pci/controller/pci-tegra.c+107 -00 replies
9/27PCI: tegra: Enable opportunistic UpdateFC and ACKdrivers/pci/controller/pci-tegra.c+9 -10 replies
10/27PCI: tegra: Disable AFI dynamic clock gatingdrivers/pci/controller/pci-tegra.c+4 -20 replies
11/27PCI: tegra: Process pending DLL transactions before entering L1 or L2drivers/pci/controller/pci-tegra.c+11 -00 replies
12/27PCI: tegra: Enable PCIe xclk clock clampingdrivers/pci/controller/pci-tegra.c+28 -20 replies
13/27PCI: tegra: Increase the deskew retry timedrivers/pci/controller/pci-tegra.c+30 -00 replies
14/27PCI: tegra: Add SW fixup for RAW violationsdrivers/pci/controller/pci-tegra.c+34 -00 replies
15/27PCI: tegra: Update flow control timer frequency in Tegra210drivers/pci/controller/pci-tegra.c+15 -00 replies
16/27PCI: tegra: Set target speed as Gen1 before starting LTSSMdrivers/pci/controller/pci-tegra.c+11 -00 replies
17/27PCI: tegra: Fix PLLE power down issue due to CLKREQ# signaldrivers/pci/controller/pci-tegra.c+12 -10 replies
18/27PCI: tegra: Program AFI_CACHE* registers only for Tegra20drivers/pci/controller/pci-tegra.c+13 -52 replies
19/27PCI: tegra: Change PRSNT_SENSE IRQ log to debugdrivers/pci/controller/pci-tegra.c+1 -10 replies
20/27PCI: tegra: Disable MSI for Tegra PCIe root portdrivers/pci/quirks.c+39 -03 replies
21/27PCI: tegra: Add AFI_PEX2_CTRL reg offset as part of soc structdrivers/pci/controller/pci-tegra.c+5 -20 replies
22/27dt-bindings: pci: tegra: Document PCIe DPD pinctrl optional propDocumentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt+8 -00 replies
23/27arm64: tegra: Add PEX DPD states as pinctrl propertiesarch/arm64/boot/dts/nvidia/tegra210.dtsi+19 -01 reply
24/27PCI: tegra: Put PEX CLK & BIAS pads in DPD modedrivers/pci/controller/pci-tegra.c+12 -10 replies
25/27PCI: Add DT binding for "reset-gpios" propertyDocumentation/devicetree/bindings/pci/pci.txt+3 -00 replies
26/27PCI: tegra: Add support for GPIO based PERST#drivers/pci/controller/pci-tegra.c+39 -63 replies
27/27PCI: tegra: Change link retry log level to debugdrivers/pci/controller/pci-tegra.c+1 -10 replies

Reviews trailers per patch

25 of 27 patches have a Reviewed-by or Acked-by.

PatchThierry RedingRob Herring
1/27A-b
2/27A-b
3/27A-b
4/27A-b
5/27A-b
6/27A-b
7/27A-b
8/27A-b
9/27A-b
10/27A-b
11/27A-b
12/27A-b
13/27A-b
14/27A-b
15/27A-b
16/27A-b
17/27A-b
18/27A-b
19/27A-b
20/27
21/27A-b
22/27A-b R-b
23/27
24/27A-b
25/27A-b R-b
26/27A-b
27/27A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH V6 00/27] Enable Tegra PCIe root port features

This series of patches adds,
- Tegra root port features like Gen2, AER, etc
- Power and perf optimizations
- Fixes like "power up sequence", "dev_err prints", etc

This series of patches are tested on Tegra186 based Jetson-TX2, Tegra210 based Jetson-TX1, T124 based Jetson-TK1, Tegra20 and Tegra30 platforms.

Changes from V5 to V6:
- Patch [V4, 20/27]: Replaced pcie_pme_disable_msi() with no_msi quirk

Changes from V4 to V5:
- Patch [V4, 4/28]: Added blank line before block style comment
- Patch [V4, 22/28]: "Access endpoint config only if PCIe link is up"
patch is dropped
- Patch [V4, 27/28]:
* Updated reset gpio toggle logic to reflect active low usage
* Replaced kasprintf() with devm_kasprintf()
* Updated commit message with more information.

Changes from V3 to V4:
- Patch [V3,27/29] is dropped
- Patch [V3,28/29]: devm_gpiod_get_from_of_node() is directly used in pci-tegra driver instead of of_get_pci* wrapper function defined in Patch [V3,27/29].

Manikanta Maddireddy (27):
soc/tegra: pmc: Export tegra_powergate_power_on()
PCI: tegra: Handle failure cases in tegra_pcie_power_on()
PCI: tegra: Rearrange Tegra PCIe driver functions
PCI: tegra: Mask AFI_INTR in runtime suspend
PCI: tegra: Fix PCIe host power up sequence
PCI: tegra: Add PCIe Gen2 link speed support
PCI: tegra: Advertise PCIe Advanced Error Reporting (AER) capability
PCI: tegra: Program UPHY electrical settings for Tegra210
PCI: tegra: Enable opportunistic UpdateFC and ACK
PCI: tegra: Disable AFI dynamic clock gating
PCI: tegra: Process pending DLL transactions before entering L1 or L2
PCI: tegra: Enable PCIe xclk clock clamping
PCI: tegra: Increase the deskew retry time
PCI: tegra: Add SW fixup for RAW violations
PCI: tegra: Update flow control timer frequency in Tegra210
PCI: tegra: Set target speed as Gen1 before starting LTSSM
PCI: tegra: Fix PLLE power down issue due to CLKREQ# signal
PCI: tegra: Program AFI_CACHE* registers only for Tegra20
PCI: tegra: Change PRSNT_SENSE IRQ log to debug
PCI: tegra: Disable MSI for Tegra PCIe root port
PCI: tegra: Add AFI_PEX2_CTRL reg offset as part of soc struct
dt-bindings: pci: tegra: Document PCIe DPD pinctrl optional prop
arm64: tegra: Add PEX DPD states as pinctrl properties
PCI: tegra: Put PEX CLK & BIAS pads in DPD mode
PCI: Add DT binding for "reset-gpios" property
PCI: tegra: Add support for GPIO based PERST#
PCI: tegra: Change link retry log level to debug

 .../bindings/pci/nvidia,tegra20-pcie.txt      |   8 +
 Documentation/devicetree/bindings/pci/pci.txt |   3 +
 arch/arm64/boot/dts/nvidia/tegra210.dtsi      |  19 +
 drivers/pci/controller/pci-tegra.c            | 578 +++++++++++++++---
 drivers/pci/quirks.c                          |  39 ++
 drivers/soc/tegra/pmc.c                       |   1 +
 6 files changed, 568 insertions(+), 80 deletions(-)
Signature · 1 line
2.17.1