Skip to content

clk: tegra: EMC/MC clock fixes and improvements

Dmitry Osipenko linux-clk linux-tegra lkml 2 versions – Applied

Status from this message: Applied to clk-next

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 5 repliesApplied
  2. v15 patches 1 replySuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/5clk: tegra: emc: Don't enable EMC clock manuallydrivers/clk/tegra/clk-emc.c+0 -21 reply
2/5clk: tegra: emc: Support multiple RAM codesdrivers/clk/tegra/clk-emc.c+23 -141 reply
3/5clk: tegra: emc: Fix EMC max-rate clampingdrivers/clk/tegra/clk-emc.c+10 -71 reply
4/5clk: tegra: emc: Replace BUG() with WARN_ONCE()drivers/clk/tegra/clk-emc.c+4 -11 reply
5/5clk: tegra: divider: Mark Memory Controller clock as read-onlydrivers/clk/tegra/clk-divider.c+2 -11 reply

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by.

PatchSteev Klimaszewski
1/5
2/5T-b
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] clk: tegra: EMC/MC clock fixes and improvements

Hello,

I was helping with fixing EMC clock scaling on T124 Nyan Big and in process found some weak points in the code. Primarily the ram code parsing didn't work if device-tree defines memory timings for multiple ram codes and after fixing that I spotted few other things that could be improved.

Changelog:

v2: Corrected "Mark Memory Controller clock as read-only" patch that
had the "read-only divider" flag being set in a wrong place. Note it also turned out that this patch is needed for a proper EMC freq scaling on Tegra30 because some of memory timings may have configuration where MC clock configuration should be changed simultaneously with the EMC change and currently CLK framework reconfigure the divider back to /2 mode after EMC clock changes since it's the parent clock for MC. Although it's not really critical since system remains fully functional if MC clock configuration doesn't match the memory arbitration configuration.

Dmitry Osipenko (5):
clk: tegra: emc: Don't enable EMC clock manually
clk: tegra: emc: Support multiple RAM codes
clk: tegra: emc: Fix EMC max-rate clamping
clk: tegra: emc: Replace BUG() with WARN_ONCE()
clk: tegra: divider: Mark Memory Controller clock as read-only

 drivers/clk/tegra/clk-divider.c |  3 +-
 drivers/clk/tegra/clk-emc.c     | 57 ++++++++++++++++++++-------------
 2 files changed, 37 insertions(+), 23 deletions(-)
Signature · 1 line
2.21.0