Skip to content

Remove select CRC32 and CONFIG_CRC32

Chris Packham u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4cmd: ubifs: Remove select for non-existent optioncmd/Kconfig+0 -22 replies
2/4mtd: ubi: Remove select for non existent optiondrivers/mtd/ubi/Kconfig+0 -12 replies
3/4Remove #define CONFIG_CRC32include/image.h+0 -13 replies
4/4Remove whitelist entry for CONFIG_CRC32scripts/config_whitelist.txt+0 -12 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchStefano BabicHeiko Schocher
1/4R-b
2/4R-b
3/4R-b R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/4] Remove select CRC32 and CONFIG_CRC32

Robert points out that we have code selecting CRC32 but nothing that actually defines this config option. Similarly image.h #defines CONFIG_CRC32 but nothing tests for it.

lib/Makefile has had obj-y += crc32.o for some time. I can't find any evidence that u-boot ever had CONFIG_CRC32.

I suspect some of this may have come in when code has been imported from Linux (particularly the UBI/UBIFS code).

Chris Packham (4):
cmd: ubifs: Remove select for non-existent option
mtd: ubi: Remove select for non existent option Remove #define CONFIG_CRC32
Remove whitelist entry for CONFIG_CRC32

 cmd/Kconfig                  | 2 --
 drivers/mtd/ubi/Kconfig      | 1 -
 include/image.h              | 1 -
 scripts/config_whitelist.txt | 1 -
 4 files changed, 5 deletions(-)
Signature · 1 line
2.21.0