Skip to content

board: ti: am43xx: Enable hardware leveling

Tom Rini u-boot 1 version New

Get series with b4
b4 am 20190415121417.GV4664@bill-the-cat

Versions newest first

  1. v1 Latest3 of 6 patches 0 repliesNew

3 of 6 patches are in this archive. The cover letter announces 6.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
4/6arm: mach-omap2: am33xx: Disable EMIF_DEVOFF immediately before hw leveling+0 -03 replies
4/6arm: mach-omap2: am33xx: Disable EMIF_DEVOFF immediately before hw leveling+0 -01 reply
4/6arm: mach-omap2: am33xx: Disable EMIF_DEVOFF immediately before hw leveling+0 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/6] board: ti: am43xx: Enable hardware leveling
Quoted 67 lines · Keerthy
Quoted 64 lines · Tom Rini
Quoted 62 lines · Tero Kristo
Quoted 47 lines · Keerthy
Quoted 31 lines · keerthy
Quoted 20 lines · Tom Rini
Quoted 19 lines · keerthy
Quoted 15 lines · Tom Rini
Quoted 8 lines · Keerthy

The series adds the support for hardware leveling. This needs the kernel to be patched with hardware leveling support and the kernel support is already in linux-next:

https://patchwork.kernel.org/project/linux-omap/list/?series=100273

Match recommended values from EMIF Tools app note:
http://www.ti.com/lit/an/sprac70/sprac70.pdf

What happens if you boot an old kernel with this series applied? I'm a
bit worried about applying something that breaks existing kernels, thanks!

Quoted 7 lines
Quoted 4 lines

Hi Tom,

Deep Sleep 0 feature will fail as the corresponding hardware leveling patches will not be present.

So to be clear, some new functionality will not work, but there is no functional regression?

Quoted 7 lines

Okay i got your concern. Deep sleep 0 is currently working with software leveling that will stop working with this patch series(hardware leveling) applied on older kernels. EMIF tools application note recommends hardware leveling over what existed previously.

Hence i posted this series. Older kernels with this patch series Deep sleep 0 feature will regress.

Tom,

We need hardware leveling as per EMIF document. So older kernels at best can backport the patches here:

Quoted 8 lines

https://patchwork.kernel.org/patch/10882123/
https://patchwork.kernel.org/patch/10882127/

I do not see any other way to enable hardware leveling.

Tero/Dave,

Any concerns?

Well, if we are to enable the feature, I can't see how we can avoid conflict with older kernels. However, most of the time I would say people upgrade their kernel before upgrading u-boot so this should be fine. If we are really worried, we could maybe add the support to kernel first, wait some time and merge the support to u-boot after that.

Quoted 8 lines
Quoted 4 lines

I assume that as the patches are working their way through -next now, we're also talking about older vendor tree kernels being where this did work?

older kernels will have to port the above patches else Deep Sleep 0 will fail with newer u-boot with hardware leveling enabled. I assume they would be using older u-boot as well?

Yes, it sounds like there's reasonable support matrices here, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190415/befec6d6/attachment.sig>