Skip to content

connection tracking support for bridge

Pablo Neira Ayuso netdev netfilter-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 1 replyIn review
  2. v29 patches 1 replySuperseded
  3. v110 patches 2 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9net: ipv4: add skbuff fraglist splitterinclude/net/ip.h net/ipv4/ip_output.c+78 -330 replies
2/9net: ipv6: add skbuff fraglist splitterinclude/net/ipv6.h net/ipv6/ip6_output.c+102 -550 replies
3/9net: ipv4: split skbuff into fragments transformerinclude/net/ip.h net/ipv4/ip_output.c+128 -880 replies
4/9net: ipv6: split skbuff into fragments transformerinclude/net/ipv6.h net/ipv6/ip6_output.c+126 -760 replies
5/9net: ipv4: place control buffer handling away from fragmentation iteratorsnet/ipv4/ip_output.c+37 -180 replies
6/9netfilter: nf_conntrack: allow to register bridge supportinclude/net/netfilter/nf_conntrack.h include/net/netfilter/nf_conntrack_bridge.h net/netfilter/nf_conntrack_proto.c+72 -30 replies
7/9netfilter: bridge: add connection tracking systeminclude/net/netfilter/nf_conntrack_bridge.h include/net/netfilter/nf_conntrack_core.h net/bridge/br_device.c +5 more+410 -40 replies
8/9netfilter: nf_conntrack_bridge: add support for IPv6include/linux/netfilter_ipv6.h net/bridge/netfilter/nf_conntrack_bridge.c net/ipv6/netfilter.c+230 -20 replies
9/9netfilter: nf_conntrack_bridge: register inet conntrack for bridgenet/netfilter/nf_conntrack_proto.c+42 -160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH net-next,v3 0/9] connection tracking support for bridge

Hi,

This patchset adds native connection tracking support for the bridge.

Patch #1 and #2 extract code from IPv4/IPv6 fragmentation core and introduce the fraglist splitter. That splits a skbuff fraglist into independent fragments.

Patch #3 and #4 also extract code from IPv4/IPv6 fragmentation core and introduce the skbuff into fragments transformer. This can be used by linearized skbuffs (eg. coming from nfqueue and ct helpers) as well as cloned skbuffs (that are either seen either with taps or with bridge port flooding).

Patch #5 moves the specific IPCB() code from these new fragment splitter/transformer APIs into the IPv4 stack. The bridge has a different control buffer layout and it starts using this new APIs in this patchset.

Patch #6 adds basic infrastructure that allows to register bridge conntrack support.

Patch #7 adds bridge conntrack support (only for IPv4 in this patch).

Patch #8 adds IPv6 support for the bridge conntrack support.

Patch #9 registers the IPv4/IPv6 conntrack hooks in case the bridge conntrack is used to deal with local traffic, ie. prerouting -> input bridge hook path. This cover the bridge interface has a IP address scenario.

Before this patchset, only chance for people to do stateful filtering is to use the br_netfilter emulation layer, that turns bridge frame into IPv4/IPv6 packets and inject them into the IPv4/IPv6 hooks. Apparently, this module allows users to use iptables and all of its feature-set from the bridge, including stateful filtering. However, this approach is flawed in many aspects that have been discussed many times. This is a step forward to deprecate `br_netfilter'.

v2: Fix English typo in commit message.
v3: Fix another English typo in commit message.

Please, apply. Thanks.

Pablo Neira Ayuso (9):
net: ipv4: add skbuff fraglist splitter
net: ipv6: add skbuff fraglist splitter
net: ipv4: split skbuff into fragments transformer
net: ipv6: split skbuff into fragments transformer
net: ipv4: place control buffer handling away from fragmentation iterators
netfilter: nf_conntrack: allow to register bridge support
netfilter: bridge: add connection tracking system
netfilter: nf_conntrack_bridge: add support for IPv6
netfilter: nf_conntrack_bridge: register inet conntrack for bridge

 include/linux/netfilter_ipv6.h              |  50 ++++
 include/net/ip.h                            |  39 +++
 include/net/ipv6.h                          |  44 +++
 include/net/netfilter/nf_conntrack.h        |   1 +
 include/net/netfilter/nf_conntrack_bridge.h |  20 ++
 include/net/netfilter/nf_conntrack_core.h   |   3 +
 net/bridge/br_device.c                      |   1 +
 net/bridge/br_private.h                     |   1 +
 net/bridge/netfilter/Kconfig                |  14 +
 net/bridge/netfilter/Makefile               |   3 +
 net/bridge/netfilter/nf_conntrack_bridge.c  | 433 ++++++++++++++++++++++++++++
 net/ipv4/ip_output.c                        | 309 ++++++++++++--------
 net/ipv6/ip6_output.c                       | 315 +++++++++++---------
 net/ipv6/netfilter.c                        | 123 ++++++++
 net/netfilter/nf_conntrack_proto.c          | 126 ++++++--
 15 files changed, 1206 insertions(+), 276 deletions(-)
 create mode 100644 include/net/netfilter/nf_conntrack_bridge.h
 create mode 100644 net/bridge/netfilter/nf_conntrack_bridge.c
Signature · 1 line
2.11.0