mmc: meson-gx: clean up and tuning update
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest7 patches 16 repliesIn review
- v17 patches 8 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | mmc: meson-gx: remove open coded read with timeoutdrivers/ | +4 | 0 replies | |
| 2/7 | mmc: meson-gx: ack only raised irqdrivers/ | +3 | 1 reply | |
| 3/7 | mmc: meson-gx: correct irq flagdrivers/ | +1 | 1 reply | |
| 4/7 | mmc: meson-gx: disable HS400drivers/ | +7 | 6 replies | |
| 5/7 | mmc: meson-gx: avoid clock glitch when switching to DDR modesdrivers/ | +43 | 1 reply | |
| 6/7 | mmc: meson-gx: remove Rx phase tuningdrivers/ | +13 | 1 reply | |
| 7/7 | mmc: meson-gx: add signal resampling tuningdrivers/ | +70 | 1 reply |
Reviews trailers per patch
4 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Martin Blumenstingl | Kevin Hilman |
|---|---|---|
| Series | R-b | |
| 1/7 | R-b | |
| 2/7 | A-b | |
| 3/7 | R-b | |
| 4/7 | A-b A-b | |
| 5/7 | T-b | |
| 6/7 | T-b | |
| 7/7 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/7] mmc: meson-gx: clean up and tuning update
The purpose of this series is too improve reliability of the amlogic mmc driver on new (g12a) and old ones (axg, gxl, gxbb, etc...)
* The 3 first patches are just harmless clean ups.
* Patch 4 makes sure HS400 can't be enabled, we still have not been able to crack this modes.
* Patch 5 removes some clock glitches when switching to DDR modes
* Patch 6 and 7 changes the tuning method from Rx phase to signal resampling. It could have been done in a single patch but the unified diff was extremely ugly. The change has been split in two patches to ease review.
The last tuning update that went through was meant to improve the axg support. Since then, it was reported to break some other boards, like the s912 vim2.
Also with the current tuning method, it was impossible to find phase settings which would work on all the SoCs, including the new ones.
After redoing all the tests from scratch, it appeared that Rx phase made (strangely) almost no difference, especially on g12a and axg. However, it showed that it is important to have a phase shift between the Core and Tx clock, 180 works best.
I discussed the test results with Amlogic. They suggested to use 180/0 or 0/180 for the Core and Tx phase. For tuning, they suggested to use signal resampling.
So far, so good ... here the platform and modes tested:
NanoPi-K2 (S905): SD UHS SDR50/DDR50, SDIO HS
Odroid-C2 (S905): SD UHS SDR50/DDR50, eMMC DDR52/HS200 (16GB module) Khadas Vim (S905X): SD HS, SDIO HS, eMMC HS200
Libretech CC (S905X): SD HS, eMMC HS200
Khadas Vim2 (S912): SD HS, SDIO HS, eMMC HS200
S400 (A113D): SDIO UHS SDR104, eMMC DDR52/HS200
U200 (S905D2): SD HS, eMMC DDR52/HS200
SEI510 (S905X2): SD HS, eMMC DDR52/HS200
Changes since v1 [0]:
* Add missing writel in patch 5 (error when switching width)
* Change patch 3 commit description
[0]: https://lkml.kernel.org/r/[email protected]
Jerome Brunet (7):
mmc: meson-gx: remove open coded read with timeout
mmc: meson-gx: ack only raised irq
mmc: meson-gx: correct irq flag
mmc: meson-gx: disable HS400
mmc: meson-gx: avoid clock glitch when switching to DDR modes
mmc: meson-gx: remove Rx phase tuning
mmc: meson-gx: add signal resampling tuning
drivers/mmc/host/meson-gx-mmc.c | 419 +++++++++----------------------- 1 file changed, 114 insertions(+), 305 deletions(-)
Signature · 1 line
2.20.1