Skip to content

Add drive-strength in Meson pinctrl driver

Guillaume La Roque linux-amlogic linux-devicetree linux-gpio lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest6 patches 1 replyIn review
  2. v56 patches 8 repliesSuperseded
  3. v4 posting 2/26 patches 2 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v4 posting 1/21 of 6 patches0 repliesSuperseded
v36 patches9 repliesSuperseded
v24 patches13 repliesSuperseded

Changes in v6 from the cover letter

- restore Tested-by/Reviewed-by/Ack-by tags

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6dt-bindings: pinctrl: add a 'drive-strength-microamp' propertyDocumentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt+3 -00 replies
2/6pinctrl: generic: add new 'drive-strength-microamp' property supportdrivers/pinctrl/pinconf-generic.c include/linux/pinctrl/pinconf-generic.h+5 -00 replies
3/6dt-bindings: pinctrl: meson: Add drive-strength-microamp propertyDocumentation/devicetree/bindings/pinctrl/meson,pinctrl.txt+4 -00 replies
4/6pinctrl: meson: Rework enable/disable bias partdrivers/pinctrl/meson/pinctrl-meson.c+49 -360 replies
5/6pinctrl: meson: add support of drive-strength-microampdrivers/pinctrl/meson/pinctrl-meson.c drivers/pinctrl/meson/pinctrl-meson.h+116 -10 replies
6/6pinctrl: meson: g12a: add DS bank valuedrivers/pinctrl/meson/pinctrl-meson-g12a.c+18 -180 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchJerome BrunetMartin BlumenstinglRob Herring
SeriesT-b
1/6A-b R-b R-b
2/6
3/6R-b R-b
4/6R-b T-b
5/6R-b T-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/6] Add drive-strength in Meson pinctrl driver

The purpose of this patchset is to add drive-strength support in meson pinconf driver. This is a new feature that was added on the g12a. It is critical for us to support this since many functions are failing with default pad drive-strength.

The value achievable by the SoC are 0.5mA, 2.5mA, 3mA and 4mA and the DT property 'drive-strength' is expressed in mA.
So this patch add another generic property "drive-strength-microamp". The change to do so would be minimal and could be benefit to other platforms later on.

Cheers
Guillaume

Changes since v5:
- restore Tested-by/Reviewed-by/Ack-by tags

Changes since v4:
- fix dt-binding documentation
- rename drive-strength-uA to drive-strength-microamp in coverletter

Changes since v3:
- remove dev_err in meson_get_drive_strength
- cleanup code

Changes since v2:
- rename driver-strength-uA property to drive-strength-microamp
- rework patch series for better understanding
- rework set_bias function

Changes since v1:
- fix missing break
- implement new pinctrl generic property "drive-strength-uA"

[1] https://lkml.kernel.org/r/[email protected]

Guillaume La Roque (6):
dt-bindings: pinctrl: add a 'drive-strength-microamp' property
pinctrl: generic: add new 'drive-strength-microamp' property support
dt-bindings: pinctrl: meson: Add drive-strength-microamp property
pinctrl: meson: Rework enable/disable bias part
pinctrl: meson: add support of drive-strength-microamp
pinctrl: meson: g12a: add DS bank value

 .../bindings/pinctrl/meson,pinctrl.txt        |   4 +
 .../bindings/pinctrl/pinctrl-bindings.txt     |   3 +
 drivers/pinctrl/meson/pinctrl-meson-g12a.c    |  36 ++--
 drivers/pinctrl/meson/pinctrl-meson.c         | 180 ++++++++++++++----
 drivers/pinctrl/meson/pinctrl-meson.h         |  18 +-
 drivers/pinctrl/pinconf-generic.c             |   2 +
 include/linux/pinctrl/pinconf-generic.h       |   3 +
 7 files changed, 193 insertions(+), 53 deletions(-)
Signature · 1 line
2.17.1