Skip to content

Fix misuse of ctype.h functions

Markus Armbruster qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 8 repliesIn review
  2. v16 patches 23 repliesSuperseded

Changes in v2 from the cover letter

* PATCH 1: Use g_ascii_isspace(), adapt commit message [Philippe]
* PATCH 3: Add comment pointing to the GDB manual [Philippe]
* PATCH 5: Improve commit message [Thomas]

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6qemu-bridge-helper: Fix misuse of isspace()qemu-bridge-helper.c+3 -30 replies
2/6tests/vhost-user-bridge: Fix misuse of isdigit()tests/vhost-user-bridge.c+1 -14 replies
3/6gdbstub: Reject invalid RLE repeat countsgdbstub.c+5 -10 replies
4/6gdbstub: Fix misuse of isxdigit()gdbstub.c+7 -70 replies
5/6pc-bios/s390-ccw: Clean up harmless misuse of isdigit()pc-bios/s390-ccw/libc.c pc-bios/s390-ccw/menu.c+2 -22 replies
6/6cutils: Simplify how parse_uint() checks for whitespaceutil/cutils.c+1 -11 reply

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchChristian BorntraegerPhilippe Mathieu-DaudéThomas Huth
1/6
2/6R-b R-b
3/6R-b
4/6
5/6A-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/6] Fix misuse of ctype.h functions

v2:
* PATCH 1: Use g_ascii_isspace(), adapt commit message [Philippe]
* PATCH 3: Add comment pointing to the GDB manual [Philippe]
* PATCH 5: Improve commit message [Thomas]

Markus Armbruster (6):
qemu-bridge-helper: Fix misuse of isspace() tests/vhost-user-bridge: Fix misuse of isdigit()
gdbstub: Reject invalid RLE repeat counts
gdbstub: Fix misuse of isxdigit() pc-bios/s390-ccw: Clean up harmless misuse of isdigit()
cutils: Simplify how parse_uint() checks for whitespace

 gdbstub.c                 | 20 ++++++++++++--------
 pc-bios/s390-ccw/libc.c   |  2 +-
 pc-bios/s390-ccw/menu.c   |  2 +-
 qemu-bridge-helper.c      |  6 +++---
 tests/vhost-user-bridge.c |  2 +-
 util/cutils.c             |  2 +-
 6 files changed, 19 insertions(+), 15 deletions(-)
Signature · 1 line
2.17.2