Skip to content

RFC Start some re-org around IRQ.

Rodrigo Vivi intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest8 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/i915: Introduce intel_irqdrivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/i915_drv.c drivers/gpu/drm/i915/i915_drv.h +9 more+155 -1510 replies
2/8drm/i915: Move IRQ related stuff from intel_rps to the new intel_irq.drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_irq.c+24 -252 replies
3/8drm/i915: Move display_irqs_enabled to intel_irqdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/intel_hotplug.c+18 -170 replies
4/8drm/i915: Consolidated iir, imr and ier.drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_irq.c+17 -170 replies
5/8drm/i915: Move all irq related masks to intel_irqdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/intel_ringbuffer.c+53 -530 replies
6/8drm/i915: Prefer passing intel_irq instead of intel_coredrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_irq.c+122 -1180 replies
7/8drm/i915: Start the conversion from passing intel_irq instead of dev_priv/i915drivers/gpu/drm/i915/i915_irq.c+29 -280 replies
8/8drm/i915: Migrate more gen11 irq functions towards intel_irq and uncore funcs.drivers/gpu/drm/i915/i915_irq.c+20 -160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/8] Start some re-org around IRQ.

When playing with IRQ code here I noticed many IRQ stuff are spreaded all around our code. So I'm starting the organization by consolidating as much as possible on a new intel_irq.

So we could use this intel_irq to pass around as argument instead of dev_priv, i915 or uncore.

So, besides starting that change we need to continue working towards the conversion of intel_uncore_*().

Another possibilities to exploer after that is to fully split rps and hotplug code out of irq.

Latest but not least it may be possible to split gt_irq from de_irq later.

But well, for now please give feed back on intel_irq struct idea.

Thanks,
Rodrigo.

Rodrigo Vivi (8):
drm/i915: Introduce intel_irq
drm/i915: Move IRQ related stuff from intel_rps to the new intel_irq. drm/i915: Move display_irqs_enabled to intel_irq
drm/i915: Consolidated iir, imr and ier.
drm/i915: Move all irq related masks to intel_irq drm/i915: Prefer passing intel_irq instead of intel_core drm/i915: Start the conversion from passing intel_irq instead of

    dev_priv/i915

drm/i915: Migrate more gen11 irq functions towards intel_irq and
uncore funcs.

 drivers/gpu/drm/i915/i915_debugfs.c        |   8 +-
 drivers/gpu/drm/i915/i915_drv.c            |   6 +-
 drivers/gpu/drm/i915/i915_drv.h            |  39 +-
 drivers/gpu/drm/i915/i915_irq.c            | 642 +++++++++++----------
 drivers/gpu/drm/i915/intel_breadcrumbs.c   |   8 +-
 drivers/gpu/drm/i915/intel_display.c       |   4 +-
 drivers/gpu/drm/i915/intel_drv.h           |   2 +-
 drivers/gpu/drm/i915/intel_engine_types.h  |   2 +-
 drivers/gpu/drm/i915/intel_fifo_underrun.c |  30 +-
 drivers/gpu/drm/i915/intel_hotplug.c       |  48 +-
 drivers/gpu/drm/i915/intel_ringbuffer.c    |  16 +-
 drivers/gpu/drm/i915/intel_runtime_pm.c    |   8 +-
 drivers/gpu/drm/i915/intel_tv.c            |   8 +-
 13 files changed, 417 insertions(+), 404 deletions(-)
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx