Skip to content

nfsd: ensure we wake file lock waiters before deleting blocked lock

Jeff Layton linux-cifs linux-nfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 7 repliesIn review
  2. v11 patch 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2nfsd: wake waiters blocked on file_lock before deleting itfs/nfsd/nfs4state.c+1 -29 replies
2/2nfsd: wake blocked file lock waiters before sending callbackfs/nfsd/nfs4state.c+9 -01 reply

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchJeff Layton
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] nfsd: ensure we wake file lock waiters before deleting blocked lock

This is a respin of the patch that I sent over the weekend. It's a bit more obvious to just call locks_delete_block from free_blocked_lock, and that allows us to remove that call from some other sites.

Still though, I think we probably do want to wake blocked lock requests prior to sending a callback to ensure that they can make progress when the callback isn't getting a reply. The second patch does this.

Jeff Layton (2):
nfsd: wake waiters blocked on file_lock before deleting it
nfsd: wake blocked file lock waiters before sending callback

 fs/nfsd/nfs4state.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
Signature · 1 line
2.20.1