Skip to content

block/stream: get rid of the base

Vladimir Sementsov-Ogievskiy qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 8 repliesIn review
  2. v53 patches 1 replySuperseded

v4 from the cover letter

trace_stream_start reverted to the base. bdrv_is_allocated_above_inclusive() deleted and the new parameter 'bool include_base' was added to the bdrv_is_allocated_above().

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3block: include base when checking image chain for block allocationblock/commit.c block/io.c block/mirror.c +3 more+20 -111 reply
2/3block/stream: refactor stream_run: drop gotoblock/stream.c+4 -91 reply
3/3block/stream: introduce a bottom nodeblock/stream.c tests/qemu-iotests/245+27 -265 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchVladimir Sementsov-OgievskiyAlberto GarciaMax Reitz
1/3R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [Qemu-devel] [PATCH v6 0/3] block/stream: get rid of the base

This series introduces a bottom intermediate node that eliminates the dependency on the base that may change while stream job is running. It happens when stream/commit parallel jobs are running on the same backing chain. The base node of the stream job may be a top node of the parallel commit job and can change before the stream job is completed. We avoid that dependency by introducing the bottom node.

v6: [resend by Vladimir]
01: improve comment in block/io.c, suggested by Alberto

v5: [resend by Vladimir]
01: use comment wording in block/io.c suggested by Alberto Now the whole series are reviewed-by Alberto and me.

v4:
trace_stream_start reverted to the base. bdrv_is_allocated_above_inclusive() deleted and the new parameter 'bool include_base' was added to the bdrv_is_allocated_above().

Andrey Shinkevich (2):
block: include base when checking image chain for block allocation block/stream: introduce a bottom node

Vladimir Sementsov-Ogievskiy (1):
block/stream: refactor stream_run: drop goto

 include/block/block.h  |  3 +-
 block/commit.c         |  2 +-
 block/io.c             | 20 ++++++++++----
 block/mirror.c         |  2 +-
 block/replication.c    |  2 +-
 block/stream.c         | 62 ++++++++++++++++++++----------------------
 tests/qemu-iotests/245 |  4 +--
 7 files changed, 50 insertions(+), 45 deletions(-)
Signature · 1 line
2.18.0