Skip to content

fw_cfg: Improve tracing

Philippe Mathieu-Daudé qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest7 patches 13 repliesIn review

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7hw/nvram/fw_cfg: Add trace eventshw/nvram/fw_cfg.c hw/nvram/trace-events+68 -20 replies
2/7hw/nvram/fw_cfg: Add fw_cfg_arch_key_name()MAINTAINERS hw/nvram/fw_cfg.c include/hw/nvram/fw_cfg.h +2 more+35 -11 reply
3/7hw/i386: Extract fw_cfg definitions to local "fw_cfg.h"hw/i386/fw_cfg.h hw/i386/pc.c+21 -62 replies
4/7hw/i386: Implement fw_cfg_arch_key_name()hw/i386/Makefile.objs hw/i386/fw_cfg.c+39 -11 reply
5/7hw/ppc: Implement fw_cfg_arch_key_name()hw/ppc/Makefile.objs hw/ppc/fw_cfg.c+46 -16 replies
6/7hw/sparc: Implement fw_cfg_arch_key_name()hw/sparc/sun4m.c+19 -01 reply
7/7hw/sparc64: Implement fw_cfg_arch_key_name()hw/sparc64/sun4u.c+19 -01 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchMichael S. TsirkinLaszlo Ersek
1/7R-b R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/7] fw_cfg: Improve tracing

Trivial series to improve fw_cfg tracing.

Regards,

Phil.

Since v2: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg02522.html
- Split arch-specific code (1 patch per arch) (requested by Laszlo)

Since v1: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg01598.html
- Added arch-specific keys

Philippe Mathieu-Daudé (7):
hw/nvram/fw_cfg: Add trace events hw/nvram/fw_cfg: Add fw_cfg_arch_key_name() hw/i386: Extract fw_cfg definitions to local "fw_cfg.h" hw/i386: Implement fw_cfg_arch_key_name() hw/ppc: Implement fw_cfg_arch_key_name() hw/sparc: Implement fw_cfg_arch_key_name() hw/sparc64: Implement fw_cfg_arch_key_name()

 MAINTAINERS               |  1 +
 hw/i386/Makefile.objs     |  2 +-
 hw/i386/fw_cfg.c          | 38 +++++++++++++++++++++++
 hw/i386/fw_cfg.h          | 20 +++++++++++++
 hw/i386/pc.c              |  7 +----
 hw/nvram/fw_cfg.c         | 63 ++++++++++++++++++++++++++++++++++++++-
 hw/nvram/trace-events     |  7 ++++-
 hw/ppc/Makefile.objs      |  2 +-
 hw/ppc/fw_cfg.c           | 45 ++++++++++++++++++++++++++++
 hw/sparc/sun4m.c          | 19 ++++++++++++
 hw/sparc64/sun4u.c        | 19 ++++++++++++
 include/hw/nvram/fw_cfg.h | 11 +++++++
 stubs/Makefile.objs       |  1 +
 stubs/fw_cfg.c            | 21 +++++++++++++
 14 files changed, 246 insertions(+), 10 deletions(-)
 create mode 100644 hw/i386/fw_cfg.c
 create mode 100644 hw/i386/fw_cfg.h
 create mode 100644 hw/ppc/fw_cfg.c
 create mode 100644 stubs/fw_cfg.c
Signature · 1 line
2.20.1