Skip to content

Fix fallouts from LINUX_BUILD_CMDS simplification

Thomas Petazzoni buildroot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5linux: split calling "all" and "$(LINUX_TARGET_NAME)" targetslinux/linux.mk+2 -12 replies
2/5configs/beaglebone: kernel build needs mkimageconfigs/beaglebone_defconfig+2 -02 replies
3/5configs/qemu_nios2_10m50: kernel build needs mkimageconfigs/qemu_nios2_10m50_defconfig+3 -02 replies
4/5configs/qemu_ppc_mpc8544ds: kernel build needs mkimageconfigs/qemu_ppc_mpc8544ds_defconfig+3 -02 replies
5/5configs/qemu_ppc_virtex_ml507: kernel build needs mkimageconfigs/qemu_ppc_virtex_ml507_defconfig+3 -02 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchYann E. MORIN
1/5
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Buildroot] [PATCH 0/5] Fix fallouts from LINUX_BUILD_CMDS simplification

Hello,

In commit ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed, a patch of mine changed LINUX_BUILD_CMDS to do "make all $(LINUX_TARGET_NAME)" instead of "make $(LINUX_TARGET_NAME)" and "make modules".

This has caused a number of build issues in our defconfigs:

- A number of kernel configurations apparently don't build well when the "all" target is built concurrently with $(LINUX_TARGET_NAME), with weird file not found errors.

   We fix this by doing "make all" and "make $(LINUX_TARGET_NAME)"
   separately (first patch)

- Due to calling "make all", a little bit more might get built, and sometimes this "little bit more" needs mkimage, so we add host-uboot-tools to the defconfig. This is enough as linux/linux.mk automatically adds host-uboot-tools to its dependency if it's enabled. I hesitated with adding an explicit BR2_LINUX_KERNEL_NEEDS_HOST_UBOOT_TOOLS option, let me know if this sounds better or if the proposed solution in this patch series is good enough.

Thanks,

Thomas

Thomas Petazzoni (5):
linux: split calling "all" and "$(LINUX_TARGET_NAME)" targets configs/beaglebone: kernel build needs mkimage configs/qemu_nios2_10m50: kernel build needs mkimage configs/qemu_ppc_mpc8544ds: kernel build needs mkimage configs/qemu_ppc_virtex_ml507: kernel build needs mkimage

 configs/beaglebone_defconfig            | 2 ++
 configs/qemu_nios2_10m50_defconfig      | 3 +++
 configs/qemu_ppc_mpc8544ds_defconfig    | 3 +++
 configs/qemu_ppc_virtex_ml507_defconfig | 3 +++
 linux/linux.mk                          | 3 ++-
 5 files changed, 13 insertions(+), 1 deletion(-)
Signature · 1 line
2.20.1