Fix fallouts from LINUX_BUILD_CMDS simplification
Get series with b4
b4 am 20190422203441.GC6200@scaerVersions newest first
- v1 Latest5 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | linux: split calling "all" and "$(LINUX_TARGET_NAME)" targets | +0 | 0 replies | |
| 2/5 | configs/beaglebone: kernel build needs mkimage | +0 | 0 replies | |
| 3/5 | configs/qemu_nios2_10m50: kernel build needs mkimage | +0 | 0 replies | |
| 4/5 | configs/qemu_ppc_mpc8544ds: kernel build needs mkimage | +0 | 0 replies | |
| 5/5 | configs/qemu_ppc_virtex_ml507: kernel build needs mkimage | +0 | 0 replies |
Reviews trailers per patch
4 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Yann E. MORIN |
|---|---|
| 1/5 | |
| 2/5 | R-b |
| 3/5 | R-b |
| 4/5 | R-b |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Buildroot] [PATCH 0/5] Fix fallouts from LINUX_BUILD_CMDS simplification
Thomas, All,
On 2019-04-22 22:08 +0200, Thomas Petazzoni spake thusly:
Quoted 8 lines
- Due to calling "make all", a little bit more might get built, and sometimes this "little bit more" needs mkimage, so we add host-uboot-tools to the defconfig. This is enough as
linux/linux.mkautomatically adds host-uboot-tools to its dependency if it's enabled. I hesitated with adding an explicitBR2_LINUX_KERNEL_NEEDS_HOST_UBOOT_TOOLSoption, let me know if this sounds better or if the proposed solution in this patch series is good enough.
Ithink the NEEDS_FOO options are only interesting when the host package does not have a kconfig option of its own.
In this case, I think it is correct to do as you did.
If linux did not have a conditional dependency on host-uboot-tools, then it should be added, rather than add a NEEDS_HOST_UBOOT_TOOLS.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'