Skip to content

tests/qemu-iotests: Run basic iotests during "make check"

Thomas Huth qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 21 repliesIn review
  2. v28 patches 20 repliesSuperseded
  3. v16 patches 31 repliesSuperseded

Changes in v3 from the cover letter

- Rebase to master, solved trivial conflict with new iotest 249 (and the patch to fix the "qemu-io" output has already been merged)
- Removed some more tests from the "auto" group that failed in certain environments
- Added Reviewed-by tags

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7tests/qemu-iotests/005: Add a sanity check for large sparse file supporttests/qemu-iotests/005+9 -01 reply
2/7tests/qemu-iotests/check: Pick a default machine if necessarytests/qemu-iotests/check+12 -10 replies
3/7tests/qemu-iotests: Do not hard-code the path to bashtests/qemu-iotests/239 tests/qemu-iotests/240 tests/qemu-iotests/241 +2 more+5 -50 replies
4/7cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD.cirrus.yml .travis.yml+3 -20 replies
5/7tests/qemu-iotests: Remove the "_supported_os Linux" line from many teststests/qemu-iotests/001 tests/qemu-iotests/002 tests/qemu-iotests/003 +96 more+0 -990 replies
6/7tests/qemu-iotests/group: Re-use the "auto" group for tests that can always runtests/qemu-iotests/group+95 -8211 replies
7/7tests: Run the iotests during "make check" againtests/Makefile.include tests/check-block.sh tests/qemu-iotests-quick.sh+38 -2210 replies

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by.

PatchAlex BennéePhilippe Mathieu-DaudéChristian BorntraegerEric BlakeLi-Wen Hsu
1/7R-b R-b
2/7R-b R-b A-b
3/7R-b R-b A-b R-b
4/7R-b R-b A-b R-b
5/7R-b T-b A-b
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/7] tests/qemu-iotests: Run basic iotests during "make check"

People often forget to run the iotests before submitting patches or pull requests - this is likely due to the fact that we do not run the tests during our mandatory "make check" tests yet.
This patch series now changes the "auto" group to only include tests that should be safe to run in all CI environments (including FreeBSD and macOS!). Thus these iotests can now always be run during "make check" automatically, too.

v3:
- Rebase to master, solved trivial conflict with new iotest 249 (and the patch to fix the "qemu-io" output has already been merged)
- Removed some more tests from the "auto" group that failed in certain environments
- Added Reviewed-by tags

v2:
- Use "auto" group instead of adding a new "ci" group
- Adjusted the tests that are run automatically (after doing lots of CI runs on cirrus-ci.com, gitlab and travis)
- Added patch to fix the current regression with the "qemu-io:" prefix in the master branch
- Added a fix for iotest 005 on ext4 filesystems (skip it there)

Thomas Huth (7):
tests/qemu-iotests/005: Add a sanity check for large sparse file
support
tests/qemu-iotests/check: Pick a default machine if necessary tests/qemu-iotests: Do not hard-code the path to bash cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD tests/qemu-iotests: Remove the "_supported_os Linux" line from many
tests
tests/qemu-iotests/group: Re-use the "auto" group for tests that can
always run
tests: Run the iotests during "make check" again

 .cirrus.yml                 |   4 +-
 .travis.yml                 |   1 +
 tests/Makefile.include      |   8 +-
 tests/check-block.sh        |  44 +++++++--
 tests/qemu-iotests-quick.sh |   8 --
 tests/qemu-iotests/001      |   1 -
 tests/qemu-iotests/002      |   1 -
 tests/qemu-iotests/003      |   1 -
 tests/qemu-iotests/004      |   1 -
 tests/qemu-iotests/005      |   9 ++
 tests/qemu-iotests/007      |   1 -
 tests/qemu-iotests/008      |   1 -
 tests/qemu-iotests/009      |   1 -
 tests/qemu-iotests/010      |   1 -
 tests/qemu-iotests/011      |   1 -
 tests/qemu-iotests/012      |   1 -
 tests/qemu-iotests/015      |   1 -
 tests/qemu-iotests/017      |   1 -
 tests/qemu-iotests/020      |   1 -
 tests/qemu-iotests/021      |   1 -
 tests/qemu-iotests/022      |   1 -
 tests/qemu-iotests/025      |   1 -
 tests/qemu-iotests/026      |   1 -
 tests/qemu-iotests/027      |   1 -
 tests/qemu-iotests/029      |   1 -
 tests/qemu-iotests/031      |   1 -
 tests/qemu-iotests/032      |   1 -
 tests/qemu-iotests/033      |   1 -
 tests/qemu-iotests/035      |   1 -
 tests/qemu-iotests/036      |   1 -
 tests/qemu-iotests/037      |   1 -
 tests/qemu-iotests/042      |   1 -
 tests/qemu-iotests/043      |   1 -
 tests/qemu-iotests/046      |   1 -
 tests/qemu-iotests/047      |   1 -
 tests/qemu-iotests/049      |   1 -
 tests/qemu-iotests/050      |   1 -
 tests/qemu-iotests/051      |   1 -
 tests/qemu-iotests/052      |   1 -
 tests/qemu-iotests/053      |   1 -
 tests/qemu-iotests/054      |   1 -
 tests/qemu-iotests/062      |   1 -
 tests/qemu-iotests/063      |   1 -
 tests/qemu-iotests/066      |   1 -
 tests/qemu-iotests/067      |   1 -
 tests/qemu-iotests/068      |   1 -
 tests/qemu-iotests/069      |   1 -
 tests/qemu-iotests/071      |   1 -
 tests/qemu-iotests/072      |   1 -
 tests/qemu-iotests/073      |   1 -
 tests/qemu-iotests/079      |   1 -
 tests/qemu-iotests/082      |   1 -
 tests/qemu-iotests/085      |   1 -
 tests/qemu-iotests/089      |   1 -
 tests/qemu-iotests/090      |   1 -
 tests/qemu-iotests/094      |   1 -
 tests/qemu-iotests/095      |   1 -
 tests/qemu-iotests/098      |   1 -
 tests/qemu-iotests/102      |   1 -
 tests/qemu-iotests/103      |   1 -
 tests/qemu-iotests/104      |   1 -
 tests/qemu-iotests/105      |   1 -
 tests/qemu-iotests/107      |   1 -
 tests/qemu-iotests/110      |   1 -
 tests/qemu-iotests/111      |   1 -
 tests/qemu-iotests/112      |   1 -
 tests/qemu-iotests/114      |   1 -
 tests/qemu-iotests/115      |   1 -
 tests/qemu-iotests/117      |   1 -
 tests/qemu-iotests/120      |   1 -
 tests/qemu-iotests/125      |   1 -
 tests/qemu-iotests/126      |   1 -
 tests/qemu-iotests/127      |   1 -
 tests/qemu-iotests/133      |   1 -
 tests/qemu-iotests/134      |   1 -
 tests/qemu-iotests/142      |   1 -
 tests/qemu-iotests/143      |   1 -
 tests/qemu-iotests/144      |   1 -
 tests/qemu-iotests/145      |   1 -
 tests/qemu-iotests/153      |   1 -
 tests/qemu-iotests/156      |   1 -
 tests/qemu-iotests/157      |   1 -
 tests/qemu-iotests/158      |   1 -
 tests/qemu-iotests/159      |   1 -
 tests/qemu-iotests/162      |   1 -
 tests/qemu-iotests/170      |   1 -
 tests/qemu-iotests/173      |   1 -
 tests/qemu-iotests/182      |   1 -
 tests/qemu-iotests/183      |   1 -
 tests/qemu-iotests/186      |   1 -
 tests/qemu-iotests/187      |   1 -
 tests/qemu-iotests/190      |   1 -
 tests/qemu-iotests/191      |   1 -
 tests/qemu-iotests/192      |   1 -
 tests/qemu-iotests/195      |   1 -
 tests/qemu-iotests/197      |   1 -
 tests/qemu-iotests/200      |   1 -
 tests/qemu-iotests/214      |   1 -
 tests/qemu-iotests/215      |   1 -
 tests/qemu-iotests/217      |   1 -
 tests/qemu-iotests/227      |   1 -
 tests/qemu-iotests/231      |   1 -
 tests/qemu-iotests/233      |   1 -
 tests/qemu-iotests/239      |   2 +-
 tests/qemu-iotests/240      |   3 +-
 tests/qemu-iotests/241      |   2 +-
 tests/qemu-iotests/243      |   2 +-
 tests/qemu-iotests/244      |   2 +-
 tests/qemu-iotests/247      |   1 -
 tests/qemu-iotests/check    |  13 ++-
 tests/qemu-iotests/group    | 177 +++++++++++++++++++-----------------
 111 files changed, 162 insertions(+), 211 deletions(-)
 delete mode 100755 tests/qemu-iotests-quick.sh
Signature · 1 line
2.21.0