Skip to content

gdbstub: Refactor command packets handler

Jon Doron qemu-devel 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v12 Latest20 patches 10 repliesIn review
  2. v1120 patches 4 repliesSuperseded
  3. v1020 patches 1 replySuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v927 patches42 repliesSuperseded
v827 patches0 repliesSuperseded
v721 patches0 repliesSuperseded
v621 patches1 replySuperseded
v521 patches0 repliesSuperseded
v420 patches0 repliesSuperseded
v320 patches10 repliesSuperseded

Patches in v12 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20gdbstub: Add infrastructure to parse cmd packetsgdbstub.c+195 -00 replies
2/20gdbstub: Implement deatch (D pkt) with new infragdbstub.c+61 -401 reply
3/20gdbstub: Implement thread_alive (T pkt) with new infragdbstub.c+32 -110 replies
4/20gdbstub: Implement continue (c pkt) with new infragdbstub.c+19 -60 replies
5/20gdbstub: Implement continue with signal (C pkt) with new infragdbstub.c+29 -50 replies
6/20gdbstub: Implement set_thread (H pkt) with new infragdbstub.c+53 -300 replies
7/20gdbstub: Implement breakpoint commands (Z/z pkt) with new infragdbstub.c+67 -191 reply
8/20gdbstub: Implement set register (P pkt) with new infragdbstub.c+30 -91 reply
9/20gdbstub: Implement get register (p pkt) with new infragdbstub.c+38 -121 reply
10/20gdbstub: Implement write memory (M pkt) with new infragdbstub.c+33 -180 replies
11/20gdbstub: Implement read memory (m pkt) with new infragdbstub.c+32 -160 replies
12/20gdbstub: Implement write all registers (G pkt) with new infragdbstub.c+31 -100 replies
13/20gdbstub: Implement read all registers (g pkt) with new infragdbstub.c+23 -80 replies
14/20gdbstub: Implement file io (F pkt) with new infragdbstub.c+26 -222 replies
15/20gdbstub: Implement step (s pkt) with new infragdbstub.c+19 -60 replies
16/20gdbstub: Implement v commands with new infragdbstub.c+110 -601 reply
17/20gdbstub: Implement generic set/query (Q/q pkt) with new infragdbstub.c+373 -1861 reply
18/20gdbstub: Implement target halted (? pkt) with new infragdbstub.c+25 -101 reply
19/20gdbstub: Clear unused variables in gdb_handle_packetgdbstub.c+2 -90 replies
20/20gdbstub: Implement qemu physical memory modegdbstub.c+60 -20 replies

Reviews trailers per patch

19 of 20 patches have a Reviewed-by or Acked-by.

PatchAlex Bennée
SeriesT-b
1/20R-b
2/20R-b
3/20R-b
4/20R-b
5/20R-b
6/20R-b
7/20R-b
8/20R-b
9/20R-b
10/20R-b
11/20R-b
12/20R-b
13/20R-b
14/20R-b R-b
15/20R-b
16/20R-b
17/20R-b T-b
18/20R-b
19/20R-b
20/20

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v12 thread

Cover letter [Qemu-devel] [PATCH v12 00/20] gdbstub: Refactor command packets handler

This patch series refactors the old gdbstub command packets handler with a new infrastructure which should ease extending and adding new and missing gdb command packets.

version 12 changes:
- Fixed a bug during rebase of v10 which broke:
"Implement breakpoint commands (Z/z pkt) with new infra" which basically broke the remove breakpoint command
- Changed gdb_handle_packet call to process_string_cmds with a wrapper which handles errors appropriately.
- Patches which require review:
gdbstub: Implement deatch (D pkt) with new infra
gdbstub: Implement breakpoint commands (Z/z pkt) with new infra
gdbstub: Implement set register (P pkt) with new infra
gdbstub: Implement get register (p pkt) with new infra
gdbstub: Implement file io (F pkt) with new infra
gdbstub: Implement v commands with new infra
gdbstub: Implement generic set/query (Q/q pkt) with new infra
gdbstub: Implement target halted (? pkt) with new infra
gdbstub: Implement qemu physical memory mode

version 11 changes:
- Add reviewed by tag
- Requires review:
gdbstub: Implement deatch (D pkt) with new infra
gdbstub: Implement breakpoint commands (Z/z pkt) with new infra
gdbstub: Implement set register (P pkt) with new infra
gdbstub: Implement get register (p pkt) with new infra
gdbstub: Implement file io (F pkt) with new infra
gdbstub: Implement v commands with new infra
gdbstub: Implement generic set/query (Q/q pkt) with new infra
gdbstub: Implement target halted (? pkt) with new infra
gdbstub: Implement qemu physical memory mode
- Already reviewed:
gdbstub: Add infrastructure to parse cmd packets
gdbstub: Implement thread_alive (T pkt) with new infra
gdbstub: Implement continue (c pkt) with new infra
gdbstub: Implement continue with signal (C pkt) with new infra
gdbstub: Implement set_thread (H pkt) with new infra
gdbstub: Implement write memory (M pkt) with new infra
gdbstub: Implement read memory (m pkt) with new infra
gdbstub: Implement write all registers (G pkt) with new infra
gdbstub: Implement read all registers (g pkt) with new infra
gdbstub: Implement step (s pkt) with new infra
gdbstub: Clear unused variables in gdb_handle_packet

version 10 changes:
- Remove kvm added API as this is not really required and can be accomplished by defining a coprocessor callback with a system specific xml (see: 200bf5b7ffea635079cc05fdfb363372b9544ce7)
- Remove the new QEMU extended commands to read KVM MSRs
- Various fixes from Code Review by Alex Bennee
- Change the QEMU specific command to read physical memory to non-User QEMU
- Per patch changes:
gdbstub: Add infrastructure to parse cmd packets
* remove the union for the flags in GdbCmdParseEntry
gdbstub: Implement deatch (D pkt) with new infra
* Changed default handling for error flow / command not found
gdbstub: Implement continue with signal (C pkt) with new infra
* Added comment we dont support C sig;[addr] commands
gdbstub: Implement set_thread (H pkt) with new infra
* Change num_params check to be equal and not less than
gdbstub: Implement breakpoint commands (Z/z pkt) with new infra
* Merged z/Z commands into a single patch
gdbstub: Implement read memory (m pkt) with new infra
* Change num_params check to be equal and not less than
gdbstub: Implement file io (F pkt) with new infra
* Changed to have a single command parser
gdbstub: Implement generic set/query (Q/q pkt) with new infra
* Merged q/Q and qemu.Supported patches into a single patch
gdbstub: Implement target halted (? pkt) with new infra
* Removed TODO comment and added a note about it in the commit msg
gdbstub: Implement qemu physical memory mode
* Added CONFIG_USER_ONLY where required

version 9 changes:
- checkpatch fixes

version 8 changes:
- Add new command to display the Supported qemu generic query/sets
- kvm: Add API to read/write a MSR
- Add new commands specific for qemu:
* Command to swap the memory GDB sees to be the physical memory
* Commands to read and write a MSR

version 7 changes:
- Fixed few checkpatch complaints
- Feedback from Alex Bennee

version 4-6 changes:
- mostly feedback from Richard Henderson

version 3 changes
- Split the single patch to many individual patches for easier reviewing

version 2 changes
- Code convention fixes

Jon Doron (20):
gdbstub: Add infrastructure to parse cmd packets
gdbstub: Implement deatch (D pkt) with new infra
gdbstub: Implement thread_alive (T pkt) with new infra
gdbstub: Implement continue (c pkt) with new infra
gdbstub: Implement continue with signal (C pkt) with new infra
gdbstub: Implement set_thread (H pkt) with new infra
gdbstub: Implement breakpoint commands (Z/z pkt) with new infra
gdbstub: Implement set register (P pkt) with new infra
gdbstub: Implement get register (p pkt) with new infra
gdbstub: Implement write memory (M pkt) with new infra
gdbstub: Implement read memory (m pkt) with new infra
gdbstub: Implement write all registers (G pkt) with new infra
gdbstub: Implement read all registers (g pkt) with new infra
gdbstub: Implement file io (F pkt) with new infra
gdbstub: Implement step (s pkt) with new infra
gdbstub: Implement v commands with new infra
gdbstub: Implement generic set/query (Q/q pkt) with new infra
gdbstub: Implement target halted (? pkt) with new infra
gdbstub: Clear unused variables in gdb_handle_packet
gdbstub: Implement qemu physical memory mode

 gdbstub.c | 1761 ++++++++++++++++++++++++++++++++++++++---------------
 1 file changed, 1270 insertions(+), 491 deletions(-)
Signature · 1 line
2.21.0