Skip to content

Assorted CODA fixes

Ezequiel Garcia linux-media 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 2 repliesIn review
  2. v15 patches 10 repliesSuperseded

Changes in v2 from the cover letter

* Add R-B by Philip.
* Drop the worker removal patch, which is a controversial change.
* Use video_device_node_name as suggested by Hans.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4media: coda: Print a nicer device registered messagedrivers/media/platform/coda/coda-common.c+9 -41 reply
2/4media: coda: Remove unbalanced and unneeded mutex unlockdrivers/media/platform/coda/coda-bit.c+0 -10 replies
3/4media: coda: Replace the threaded interrupt with a hard interruptdrivers/media/platform/coda/coda-common.c+2 -20 replies
4/4media: coda: Clear the interrupt reasondrivers/media/platform/coda/coda-bit.c+1 -00 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchPhilipp Zabel
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] Assorted CODA fixes

While working on a SoC with CODA980 (currently not supported by the driver), I came across some low-hanging fruit that looked worth addressing.

Patch 1 is just a cosmetic change to print a different "more standard" device registered message, if such thing exists.

Patches 2 and 3 address unneeded usage of a threaded interrupt. Careful code inspection shows the interrupt can be serviced on a normal handler.

Finally, patch 4 clears a hardware register called INT_REASON. Without this clearing the firmware has been found to get stuck on our CODA980. I believe this fix might be useful to carry upstream, because it's so small and we have some indications that it's actually the right thing to do.

Not much has changed in this series, compared to v1.

v2:

* Add R-B by Philip.
* Drop the worker removal patch, which is a controversial change.
* Use video_device_node_name as suggested by Hans.

Ezequiel Garcia (4):
media: coda: Print a nicer device registered message
media: coda: Remove unbalanced and unneeded mutex unlock
media: coda: Replace the threaded interrupt with a hard interrupt
media: coda: Clear the interrupt reason

 drivers/media/platform/coda/coda-bit.c    |  2 +-
 drivers/media/platform/coda/coda-common.c | 17 +++++++++++------
 2 files changed, 12 insertions(+), 7 deletions(-)
Signature · 1 line
2.20.1