RFC net: sched: prepare to reuse per-block callbacks from netfilter
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest9 patches 9 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | net: sched: move tcf_block_cb before indr_blocknet/ | +242 | 0 replies | |
| 2/9 | net: sched: add tcf_block_cb_alloc()include/ net/ | +21 | 0 replies | |
| 3/9 | net: sched: add tcf_block_cb_free()include/ net/ | +7 | 0 replies | |
| 4/9 | net: sched: add tcf_block_setup()include/ net/ | +107 | 0 replies | |
| 5/9 | net: sched: add release callback to struct tcf_block_cbinclude/ net/ | +10 | 0 replies | |
| 6/9 | net: sched: add tcf_setup_block_offload()drivers/ drivers/ drivers/ +14 more | +89 | 0 replies | |
| 7/9 | net: use tcf_block_setup() infrastructuredrivers/ drivers/ drivers/ +3 more | +124 | 2 replies | |
| 8/9 | net: cls_api: do not expose tcf_block to driversdrivers/ drivers/ drivers/ +3 more | +17 | 0 replies | |
| 8/9 | net: sched: remove tcf_block_cb_{register,unregister}()include/ net/ | +1 | 0 replies | |
| 9/9 | net: cls_api: do not expose tcf_block to driversdrivers/ drivers/ drivers/ +3 more | +17 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH net-next,RFC 0/9] net: sched: prepare to reuse per-block callbacks from netfilter
Hi,
This patchset aims to introduce changes to reuse the existing .ndo_setup_tc netdev operations from netfilter.
The idea is to move tcf_block_cb to net/core/flow_offload.c and rename it to flow_block_cb. This object provides the minimal infrastructure to set up per-block callbacks that are called to offload policies to hardware.
The tcf_block object is specific for TC to share policies between ingress devices. This object has a list of tcf_block_cb objects that are called to offload the policies to hardware. In netfilter, the idea is to store the list of tcf_block_cb objects in a chain that would be bound to several devices, eg.
chain x {
type filter hook ingress devices = { eth0, eth1 } priority 0;
...}
Hence, this emulates the shared blocks available in TC that Jiri made.
Note that the list of tcf_block_cb objects will be called to offload policies in this chain.
To reuse this infrastructure, I need remove the dependency with the tcf_block object and tc/cls_api (see .reoffload) that is called from the driver side, this patchset reworks the per-block callback infrastructure to set up the tcf_block_cb object from the driver, then convey the list of callbacks using the tc_block_offload object back to the core.
cls_api driver
TC_SETUP_BLOCK ----------> setup tcf_block_cb
tc_block_offload add it to tc_block_offload->cb_list
|
register <------------------------'
tcf_block_cb
->reoffloadTherefore, registration does not happen from drivers anymore, instead it is done from the core. The driver just sets up the tcf_block_cb object that wires up the connection between the offloaded block (chains in case of netfilter) and the driver.
This patchset is compile tested only at this stage.
Comments welcome, thanks.
Pablo Neira Ayuso (9):
net: sched: move tcf_block_cb before indr_block
net: sched: add tcf_block_cb_alloc()
net: sched: add tcf_block_cb_free()
net: sched: add tcf_block_setup()
net: sched: add release callback to struct tcf_block_cb
net: sched: add tcf_setup_block_offload()
net: use tcf_block_setup() infrastructure
net: sched: remove tcf_block_cb_{register,unregister}()
net: cls_api: do not expose tcf_block to drivers
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 26 +- drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 28 +- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 26 +- drivers/net/ethernet/intel/i40e/i40e_main.c | 26 +- drivers/net/ethernet/intel/iavf/iavf_main.c | 35 +- drivers/net/ethernet/intel/igb/igb_main.c | 23 +- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 27 +- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 27 +- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 59 +- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 64 ++- drivers/net/ethernet/netronome/nfp/abm/cls.c | 17 +- drivers/net/ethernet/netronome/nfp/bpf/main.c | 29 +- .../net/ethernet/netronome/nfp/flower/offload.c | 62 +-- drivers/net/ethernet/qlogic/qede/qede_main.c | 23 +- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 22 +- drivers/net/netdevsim/netdev.c | 26 +- include/net/pkt_cls.h | 29 +- net/dsa/slave.c | 15 +- net/sched/cls_api.c | 598 ++++++++++++--------- 19 files changed, 528 insertions(+), 634 deletions(-)
Signature · 1 line
2.11.0