Skip to content

vfs: track the dentry name length in name_snapshot

Jeff Layton linux-audit linux-fsdevel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5dcache: track the length of the string in struct name_snapshotfs/dcache.c fs/debugfs/inode.c fs/namei.c +4 more+14 -110 replies
2/5fsnotify: have fsnotify_move take a struct qstr instead of a stringfs/debugfs/inode.c fs/namei.c include/linux/fsnotify.h+8 -90 replies
3/5fsnotify: have fsnotify() take a qstr instead of a stringfs/kernfs/file.c fs/notify/fsnotify.c include/linux/fsnotify.h +1 more+15 -130 replies
4/5fsnotify: change ->handle_event and send_to_group to take a qstrfs/notify/dnotify/dnotify.c fs/notify/fanotify/fanotify.c fs/notify/fsnotify.c +6 more+16 -150 replies
5/5audit: fix audit_compare_dname_path to take a qstrkernel/audit.h kernel/audit_fsnotify.c kernel/audit_watch.c +2 more+13 -121 reply

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchPaul Moore
1/5
2/5
3/5
4/5
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] vfs: track the dentry name length in name_snapshot

name_snapshot will snapshot the current contents of a dentry's name for later consumption. Several of those users end up needing to do a strlen on the resulting string later. We already have that info in the original dentry though, so we can do this a bit more efficiently by stuffing the name length into the name_snapshot as well.

This is not well tested, but it built and booted. Do we have a testsuite that exercises the fsnotify code, in particular?

Jeff Layton (5):
dcache: track the length of the string in struct name_snapshot
fsnotify: have fsnotify_move take a struct qstr instead of a string
fsnotify: have fsnotify() take a qstr instead of a string
fsnotify: change ->handle_event and send_to_group to take a qstr
audit: fix audit_compare_dname_path to take a qstr

 fs/dcache.c                          | 11 +++++++----
 fs/debugfs/inode.c                   |  2 +-
 fs/kernfs/file.c                     |  6 ++++--
 fs/namei.c                           |  4 ++--
 fs/notify/dnotify/dnotify.c          |  2 +-
 fs/notify/fanotify/fanotify.c        |  2 +-
 fs/notify/fsnotify.c                 |  8 ++++----
 fs/notify/inotify/inotify.h          |  2 +-
 fs/notify/inotify/inotify_fsnotify.c |  6 +++---
 fs/overlayfs/export.c                |  2 +-
 include/linux/dcache.h               |  2 +-
 include/linux/fsnotify.h             | 17 ++++++++---------
 include/linux/fsnotify_backend.h     |  6 +++---
 kernel/audit.h                       |  3 ++-
 kernel/audit_fsnotify.c              |  5 +++--
 kernel/audit_tree.c                  |  2 +-
 kernel/audit_watch.c                 |  4 ++--
 kernel/auditfilter.c                 |  7 ++++---
 kernel/auditsc.c                     |  7 +++----
 19 files changed, 52 insertions(+), 46 deletions(-)
Signature · 1 line
2.20.1