Skip to content

Refactor to expand subslice mask

Stuart Summers intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 23 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/i915: Use local variable for SSEU info in GETPARAM ioctldrivers/gpu/drm/i915/i915_drv.c+6 -52 replies
2/6drm/i915: Add macro for SSEU stride calculationdrivers/gpu/drm/i915/gt/intel_sseu.h drivers/gpu/drm/i915/i915_query.c+10 -92 replies
3/6drm/i915: Move calculation of subslices per slice to new functiondrivers/gpu/drm/i915/gt/intel_sseu.h drivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/intel_device_info.c+9 -32 replies
4/6drm/i915: Move sseu helper functions to intel_sseu.hdrivers/gpu/drm/i915/gt/intel_sseu.h drivers/gpu/drm/i915/intel_device_info.h+47 -472 replies
5/6drm/i915: Remove inline from sseu helper functionsdrivers/gpu/drm/i915/gt/intel_sseu.c drivers/gpu/drm/i915/gt/intel_sseu.h drivers/gpu/drm/i915/i915_debugfs.c +2 more+102 -868 replies
6/6drm/i915: Expand subslice maskdrivers/gpu/drm/i915/gt/intel_engine_cs.c drivers/gpu/drm/i915/gt/intel_engine_types.h drivers/gpu/drm/i915/gt/intel_hangcheck.c +8 more+198 -1177 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchDaniele Ceraolo SpurioJani NikulaLionel Landwerlin
1/6R-b
2/6R-b
3/6R-b
4/6
5/6A-b
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/6] Refactor to expand subslice mask

This patch series contains a few code clean-up patches, followed by a patch which changes the storage of the subslice mask to better match the userspace access through the I915_QUERY_TOPOLOGY_INFO ioctl. The index into the subslice_mask array is then calculated:
slice * subslice stride + subslice index / 8

v2: fix i915_pm_sseu test failure
v3: no changes to patches in the series, just resending to pick up
in CI correctly
v4: rebase
v5: fix header test
v6: address review comments from Jari
address minor checkpatch warning in existing code use eu_stride for EU div-by-8
v7: another rebase

Stuart Summers (6):
drm/i915: Use local variable for SSEU info in GETPARAM ioctl drm/i915: Add macro for SSEU stride calculation drm/i915: Move calculation of subslices per slice to new function drm/i915: Move sseu helper functions to intel_sseu.h drm/i915: Remove inline from sseu helper functions drm/i915: Expand subslice mask

 drivers/gpu/drm/i915/gt/intel_engine_cs.c    |   6 +-
 drivers/gpu/drm/i915/gt/intel_engine_types.h |  32 +--
 drivers/gpu/drm/i915/gt/intel_hangcheck.c    |   3 +-
 drivers/gpu/drm/i915/gt/intel_sseu.c         |  85 ++++++++
 drivers/gpu/drm/i915/gt/intel_sseu.h         |  30 ++-
 drivers/gpu/drm/i915/gt/intel_workarounds.c  |   2 +-
 drivers/gpu/drm/i915/i915_debugfs.c          |  50 +++--
 drivers/gpu/drm/i915/i915_drv.c              |  15 +-
 drivers/gpu/drm/i915/i915_gpu_error.c        |   5 +-
 drivers/gpu/drm/i915/i915_query.c            |  15 +-
 drivers/gpu/drm/i915/intel_device_info.c     | 209 +++++++++++--------
 drivers/gpu/drm/i915/intel_device_info.h     |  47 -----
 12 files changed, 302 insertions(+), 197 deletions(-)
Signature · 6 lines
2.21.0.5.gaeb582a983

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx