Skip to content

fix function type mismatches in syscall wrappers

Sami Tolvanen linux-arm-kernel lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 1 replyIn review
  2. v23 patches 5 repliesSuperseded
  3. v12 patches 3 repliesSuperseded

Changes in v3 from the cover letter

- instead of SYSCALL_DEFINE0, just define __arm64_sys_ni_syscall with the correct type to avoid unnecessary error injection

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3arm64: fix syscall_fn_t typearch/arm64/include/asm/syscall.h+1 -10 replies
2/3arm64: use the correct function type in SYSCALL_DEFINE0arch/arm64/include/asm/syscall_wrapper.h+9 -90 replies
3/3arm64: use the correct function type for __arm64_sys_ni_syscallarch/arm64/kernel/sys.c arch/arm64/kernel/sys32.c+11 -100 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchMark Rutland
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] fix function type mismatches in syscall wrappers

These patches fix type mismatches in arm64 syscall wrapper definitions, which trip indirect call checks with Control-Flow Integrity.

Changes in v3:
- instead of SYSCALL_DEFINE0, just define __arm64_sys_ni_syscall with the correct type to avoid unnecessary error injection

Changes in v2:
- more informative commit message for the syscall_fn_t change
- added a patch for fixing sys_ni_syscall

Sami Tolvanen (3):
arm64: fix syscall_fn_t type
arm64: use the correct function type in SYSCALL_DEFINE0
arm64: use the correct function type for __arm64_sys_ni_syscall

 arch/arm64/include/asm/syscall.h         |  2 +-
 arch/arm64/include/asm/syscall_wrapper.h | 18 +++++++++---------
 arch/arm64/kernel/sys.c                  | 14 +++++++++-----
 arch/arm64/kernel/sys32.c                |  7 ++-----
 4 files changed, 21 insertions(+), 20 deletions(-)
Signature · 1 line
2.22.0.rc1.257.g3120a18244-goog