Skip to content

soundwire: more code cleanups

Vinod Koul alsa-devel 1 version Applied

Status from this message: I've applied both his, and your, patch series to the tree now, hopefully

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 9 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/14soundwire: fix kconfig help formatdrivers/soundwire/Kconfig+1 -16 replies
2/14soundwire: fix SPDX license for header filesinclude/linux/soundwire/sdw.h include/linux/soundwire/sdw_registers.h include/linux/soundwire/sdw_type.h+6 -60 replies
3/14soundwire: intel: fix SPDX license for header fileinclude/linux/soundwire/sdw_intel.h+2 -20 replies
4/14soundwire: remove empty line before/after bracesdrivers/soundwire/bus.c drivers/soundwire/mipi_disco.c drivers/soundwire/stream.c+0 -220 replies
5/14soundwire: cadence: remove empty line after bracesdrivers/soundwire/cadence_master.c+0 -10 replies
6/14soundwire: intel: remove empty line after bracesdrivers/soundwire/intel_init.c+0 -10 replies
7/14soundwire: add argument to function definitioninclude/linux/soundwire/sdw_type.h+1 -10 replies
8/14soundwire: more alignment fixesdrivers/soundwire/bus.c drivers/soundwire/stream.c include/linux/soundwire/sdw.h+17 -110 replies
9/14soundwire: intel: more alignment fixesdrivers/soundwire/intel.c include/linux/soundwire/sdw_intel.h+19 -190 replies
10/14soundwire: avoid multiple assignmentsdrivers/soundwire/bus.c+4 -20 replies
11/14soundwire: fix more typosdrivers/soundwire/stream.c+2 -20 replies
12/14soundwire: wrap macro argument in parenthesisinclude/linux/soundwire/sdw.h+1 -10 replies
13/14soundwire: add a blank line between functionsdrivers/soundwire/stream.c+1 -00 replies
14/14soundwire: remove multiple blank linesinclude/linux/soundwire/sdw_registers.h+0 -10 replies

Reviews trailers per patch

None of the 14 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPierre-Louis Bossart
SeriesR-b
1/14
2/14
3/14
4/14
5/14
6/14
7/14
8/14
9/14
10/14
11/14
12/14
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/14] soundwire: more code cleanups

After applying cleanup from Pierre, I realized few more things can be cleaned up as well, so fixing these instance in the subsystem.

Looks like bool is no longer encouraged, but I have skipped those and few alignment as they caused code to look worse.

Greg,
if you are okay I would like to add this as well (i know it is late, but they are cosmetic changes and no logic ones, let me know and I can send a updated PR)

Vinod Koul (14):
soundwire: fix kconfig help format
soundwire: fix SPDX license for header files
soundwire: intel: fix SPDX license for header file
soundwire: remove empty line before/after braces
soundwire: cadence: remove empty line after braces
soundwire: intel: remove empty line after braces
soundwire: add argument to function definition
soundwire: more alignment fixes
soundwire: intel: more alignment fixes
soundwire: avoid multiple assignments
soundwire: fix more typos
soundwire: wrap macro argument in parenthesis
soundwire: add a blank line between functions
soundwire: remove multiple blank lines

 drivers/soundwire/Kconfig               |  2 +-
 drivers/soundwire/bus.c                 | 17 +++++-------
 drivers/soundwire/cadence_master.c      |  1 -
 drivers/soundwire/intel.c               | 36 ++++++++++++-------------
 drivers/soundwire/intel_init.c          |  1 -
 drivers/soundwire/mipi_disco.c          |  6 -----
 drivers/soundwire/stream.c              | 28 +++++++++----------
 include/linux/soundwire/sdw.h           | 16 +++++------
 include/linux/soundwire/sdw_intel.h     |  6 ++---
 include/linux/soundwire/sdw_registers.h |  5 ++--
 include/linux/soundwire/sdw_type.h      |  6 ++---
 11 files changed, 54 insertions(+), 70 deletions(-)
Signature · 1 line
2.20.1