Skip to content

perf: Fix AUX software double buffering

Alexander Shishkin lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2perf: Fix AUX software double bufferingkernel/events/ring_buffer.c+1 -20 replies
2/2perf, pt: Remove software double buffering PMU capabilityarch/x86/events/intel/pt.c include/linux/perf_event.h+1 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] perf: Fix AUX software double buffering

Hi Peter,

There was a problem with 04fe30a61514 ("perf/ring_buffer: Use high order allocations for AUX buffers optimistically") that made buffers that were previously scattered across multiple pages into one large buffer, breaking double buffering. In practice, this manifests easily for non-privileged users, whose buffers are generally smaller than MAX_ORDER and would fit into one high-order allocation. Root's default AUX buffer size is larger and would get split, so they are less affected. The fix is trivial and we also get rid of one PMU capability as a bonus.

Alexander Shishkin (2):
perf: Fix AUX software double buffering
perf, pt: Remove software double buffering PMU capability

 arch/x86/events/intel/pt.c  | 3 +--
 include/linux/perf_event.h  | 1 -
 kernel/events/ring_buffer.c | 3 +--
 3 files changed, 2 insertions(+), 5 deletions(-)
Signature · 1 line
2.20.1