Skip to content

Refactor to expand subslice mask

Stuart Summers intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/i915: Use local variable for SSEU info in GETPARAM ioctldrivers/gpu/drm/i915/i915_drv.c+6 -50 replies
2/5drm/i915: Add macro for SSEU stride calculationdrivers/gpu/drm/i915/gt/intel_sseu.h drivers/gpu/drm/i915/i915_query.c drivers/gpu/drm/i915/intel_device_info.h+13 -150 replies
3/5drm/i915: Move calculation of subslices per slice to new functiondrivers/gpu/drm/i915/gt/intel_sseu.h drivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/intel_device_info.c+9 -30 replies
4/5drm/i915: Refactor sseu helper functionsdrivers/gpu/drm/i915/gt/intel_sseu.c drivers/gpu/drm/i915/gt/intel_sseu.h drivers/gpu/drm/i915/i915_debugfs.c +3 more+97 -832 replies
5/5drm/i915: Expand subslice maskdrivers/gpu/drm/i915/gt/intel_engine_cs.c drivers/gpu/drm/i915/gt/intel_engine_types.h drivers/gpu/drm/i915/gt/intel_hangcheck.c +8 more+227 -1194 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchDaniele Ceraolo SpurioJani NikulaLionel Landwerlin
1/5R-b
2/5R-b
3/5R-b
4/5R-b A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/5] Refactor to expand subslice mask

This patch series contains a few code clean-up patches, followed by a patch which changes the storage of the subslice mask to better match the userspace access through the I915_QUERY_TOPOLOGY_INFO ioctl. The index into the subslice_mask array is then calculated:
slice * subslice stride + subslice index / 8

v2: fix i915_pm_sseu test failure
v3: no changes to patches in the series, just resending to pick up
in CI correctly
v4: rebase
v5: fix header test
v6: address review comments from Jari
address minor checkpatch warning in existing code use eu_stride for EU div-by-8
v7: another rebase
v8: address review comments from Tvrtko and Daniele

Stuart Summers (5):
drm/i915: Use local variable for SSEU info in GETPARAM ioctl drm/i915: Add macro for SSEU stride calculation drm/i915: Move calculation of subslices per slice to new function drm/i915: Refactor sseu helper functions
drm/i915: Expand subslice mask

 drivers/gpu/drm/i915/gt/intel_engine_cs.c    |  24 +-
 drivers/gpu/drm/i915/gt/intel_engine_types.h |  30 +--
 drivers/gpu/drm/i915/gt/intel_hangcheck.c    |   3 +-
 drivers/gpu/drm/i915/gt/intel_sseu.c         |  58 +++++
 drivers/gpu/drm/i915/gt/intel_sseu.h         |  36 ++-
 drivers/gpu/drm/i915/gt/intel_workarounds.c  |   2 +-
 drivers/gpu/drm/i915/i915_debugfs.c          |  46 ++--
 drivers/gpu/drm/i915/i915_drv.c              |  15 +-
 drivers/gpu/drm/i915/i915_gpu_error.c        |   5 +-
 drivers/gpu/drm/i915/i915_query.c            |  15 +-
 drivers/gpu/drm/i915/intel_device_info.c     | 246 ++++++++++++-------
 drivers/gpu/drm/i915/intel_device_info.h     |  47 ----
 12 files changed, 327 insertions(+), 200 deletions(-)
Signature · 6 lines
2.21.0.5.gaeb582a983

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx