Skip to content

RFC nvmf auto-connect scripts

James Smart linux-nvme 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5fabrics: ignore arguments that pass in "none"fabrics.c+4 -41 reply
2/5fabrics: support persistent connections to a discovery controllerfabrics.c fabrics.h+14 -31 reply
3/5fabrics: allow discover to address discovery controller by persistent namefabrics.c+25 -109 replies
4/5fabrics: add --quiet optionfabrics.c+11 -31 reply
5/5nvmf auto-connect scriptsMakefile nvme.spec.in nvmf-autoconnect/70-nvmf-autoconnect.conf +4 more+61 -14 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH nvme-cli rfc 0/5] nvmf auto-connect scripts

This rfc is a combination of the nvme-fc auto-connect scripts posted by Hannes and the RFC from Sagi to allow auto-connect for persistent discovery controllers that send AENs. It does not contain the code that handles the AEN and generates the event.

The auto-connect scripts are now commonized with the exception of the nvme-fc boot connections service. It's expected that both the persistent discovery controllers and nvme-fc can post the same udev event. Whenever the discovery aen generates an event, the new --device=<name> argument will be used to identify the persistent discovery controller. Other connect attributes will be no-op'd by a "none" value. When nvme-fc generates it's events, it will specify --device=none and specify the discovery controller addressing arguments. If a persistent discovery controller exists on nvme-fc, will do nothing special and AEN's from it will follow the --device=<name> syntax.

The udev event handler supports both the new event to be used by discovery controllers. The nvme-fc transport will be migrated to issue the new event syntax as well. But the udev script will continue to support the older style nvme-fc event info in case it's running against an older kernel.

Feedback is welcome.

James Smart (3):
fabrics: ignore arguments that pass in "none"
fabrics: allow discover to address discovery controller by persistent
name
nvmf auto-connect scripts

Sagi Grimberg (2):
fabrics: support persistent connections to a discovery controller
fabrics: add --quiet option

 Makefile                                         | 10 +++-
 fabrics.c                                        | 70 +++++++++++++++++-------
 fabrics.h                                        |  2 +
 nvme.spec.in                                     |  8 +++
 nvmf-autoconnect/70-nvmf-autoconnect.conf        |  1 +
 nvmf-autoconnect/70-nvmf-autoconnect.rules       | 18 ++++++
 nvmf-autoconnect/nvmefc-boot-connections.service |  9 +++
 nvmf-autoconnect/nvmf-connect.target             |  2 +
 nvmf-autoconnect/nvmf-connect at .service           | 14 +++++
 9 files changed, 114 insertions(+), 20 deletions(-)
 create mode 100644 nvmf-autoconnect/70-nvmf-autoconnect.conf
 create mode 100644 nvmf-autoconnect/70-nvmf-autoconnect.rules
 create mode 100644 nvmf-autoconnect/nvmefc-boot-connections.service
 create mode 100644 nvmf-autoconnect/nvmf-connect.target
 create mode 100644 nvmf-autoconnect/nvmf-connect at .service
Signature · 1 line
2.13.7