hw/block/pflash_cfi01: Add DeviceReset() handler
Status from this message: Queued to pflash/next, thanks.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest1 patch 9 repliesApplied
- v65 patches 5 repliesSuperseded
- v55 patches 5 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 5 patches | 3 replies | Superseded | |
| v3 | 9 patches | 6 replies | Superseded | |
| v2 | 9 patches | 22 replies | Superseded | |
| v1 | 5 patches | 14 replies | Superseded |
Patches in v7 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | hw/block/pflash_cfi01: Add missing DeviceReset() handlerhw/ | +19 | 9 replies |
Reviews trailers per patch
The patch has a Reviewed-by or Acked-by.
| Patch | John Snow | Alistair Francis | Laszlo Ersek |
|---|---|---|---|
| 1/1 | R-b | R-b | Regression-tested-by Regression-tested-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [Qemu-devel] [PATCH-for-4.1 v7 0/1] hw/block/pflash_cfi01: Add DeviceReset() handler
The pflash device lacks a reset() function. When a machine is resetted, the flash might be in an inconsistent state, leading to unexpected behavior. Resolve this issue by adding a DeviceReset() handler.
v7: Surgical bugfix, do not attempt to improve the model in any
way, thus ignoring all comments from previous versions. No migration impact.
Usual regression testing is welcomed, but probably pointless, except done in the way describes in the following bug reports:
https://bugzilla.redhat.com/show_bug.cgi?id=1678713
https://bugzilla.redhat.com/show_bug.cgi?id=1704584
That is, resetting the machine when it is accessing the flash device. IMO testing after the guest is done accessing the flash device is totally pointless.
If no objection on this series after a day, I plan to send a pull request to get this bugfix into 4.1.0-rc2.
Regards,
Phil.
Philippe Mathieu-Daudé (1):
hw/block/pflash_cfi01: Add missing DeviceReset() handler
hw/block/pflash_cfi01.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
Signature · 1 line
2.20.1