Skip to content

block/pflash_cfi02: Implement missing AMD pflash functionality

Philippe Mathieu-Daudé qemu-arm qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest28 patches 26 repliesIn review
  2. v113 patches 3 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/28tests/pflash-cfi02: Add test for supported CFI commandstests/Makefile.include tests/pflash-cfi02-test.c+227 -00 replies
2/28hw/block/pflash: Simplify trace_pflash_io_read/write()hw/block/pflash_cfi01.c hw/block/pflash_cfi02.c hw/block/trace-events+7 -83 replies
3/28hw/block/pflash: Simplify trace_pflash_data_read/write()hw/block/pflash_cfi01.c hw/block/pflash_cfi02.c hw/block/trace-events+6 -121 reply
4/28hw/block/pflash_cfi02: Fix debug format stringhw/block/pflash_cfi02.c+6 -121 reply
5/28hw/block/pflash_cfi02: Add an enum to define the write cycleshw/block/pflash_cfi02.c+8 -21 reply
6/28hw/block/pflash_cfi02: Add helpers to manipulate the status bitshw/block/pflash_cfi02.c+34 -61 reply
7/28hw/block/pflash_cfi02: Simplify a statement using fall throughhw/block/pflash_cfi02.c+3 -31 reply
8/28hw/block/pflash_cfi02: Use the ldst API in pflash_write()hw/block/pflash_cfi02.c+8 -301 reply
9/28hw/block/pflash_cfi02: Use the ldst API in pflash_read()hw/block/pflash_cfi02.c+5 -271 reply
10/28hw/block/pflash_cfi02: Extract the pflash_data_read() functionhw/block/pflash_cfi02.c+14 -101 reply
11/28hw/block/pflash_cfi02: Unify the MemoryRegionOpshw/block/pflash_cfi02.c+15 -451 reply
12/28hw/block/pflash_cfi02: Fix command address comparisonhw/block/pflash_cfi02.c tests/pflash-cfi02-test.c+17 -31 reply
13/28tests/pflash-cfi02: Refactor to support testing multiple configurationstests/pflash-cfi02-test.c+277 -1091 reply
14/28hw/block/pflash_cfi02: Remove pointless local variablehw/block/pflash_cfi02.c+6 -81 reply
15/28hw/block/pflash_cfi02: Document the current CFI valueshw/block/pflash_cfi02.c+10 -11 reply
16/28hw/block/pflash_cfi02: Hold the PRI table offset in a variablehw/block/pflash_cfi02.c+17 -141 reply
17/28hw/block/pflash_cfi02: Document 'Page Mode' operations are not supportedhw/block/pflash_cfi02.c+3 -11 reply
18/28hw/block/pflash_cfi02: Implement nonuniform sector sizeshw/block/pflash_cfi02.c tests/pflash-cfi02-test.c+231 -651 reply
19/28hw/block/pflash_cfi02: Extract pflash_regions_count()hw/block/pflash_cfi02.c+6 -21 reply
20/28hw/block/pflash_cfi02: Split if() conditionhw/block/pflash_cfi02.c+4 -21 reply
21/28hw/block/pflash_cfi02: Fix CFI in autoselect modehw/block/pflash_cfi02.c tests/pflash-cfi02-test.c+57 -41 reply
22/28hw/block/pflash_cfi02: Fix reset command not ignored during erasehw/block/pflash_cfi02.c+2 -11 reply
23/28hw/block/pflash_cfi02: Implement multi-sector erasehw/block/pflash_cfi02.c tests/pflash-cfi02-test.c+137 -270 replies
24/28hw/block/pflash_cfi02: Implement erase suspend/resumehw/block/pflash_cfi02.c tests/pflash-cfi02-test.c+250 -140 replies
25/28hw/block/pflash_cfi02: Use chip erase time specified in the CFI tablehw/block/pflash_cfi02.c+2 -21 reply
26/28hw/block/pflash_cfi02: Reduce single byte/word write delayhw/block/pflash_cfi02.c+2 -20 replies
27/28hw/block/pflash_cfi02: Document commandshw/block/pflash_cfi02.c+19 -211 reply
28/28hw/block/pflash_cfi02: Reduce I/O accesses to 16-bithw/block/pflash_cfi02.c+1 -41 reply

Reviews trailers per patch

27 of 28 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéThomas HuthAlistair Francis
1/28R-b T-b
2/28R-b
3/28R-b
4/28R-b T-b R-b
5/28R-b T-b R-b
6/28R-b T-b R-b
7/28R-b T-b R-b
8/28R-b T-b R-b
9/28R-b T-b R-b
10/28R-b T-b R-b
11/28R-b T-b R-b
12/28A-b A-b
13/28A-b
14/28R-b
15/28A-b
16/28R-b
17/28R-b
18/28A-b
19/28R-b
20/28R-b
21/28A-b A-b
22/28R-b
23/28A-b
24/28A-b
25/28R-b
26/28
27/28R-b
28/28R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 00/28] block/pflash_cfi02: Implement missing AMD pflash functionality

Hi,

This series is based on Stephen Checkoway work (v4):
https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg04595.html

Stephen work is a great improvement of the actual code, however while reviewing his patches, I found them quite dense, so I started to split each logical change to be able to digest his series.

Sfephen implemented the 'interleaving' feature in way I am not yet confident it is in the project best interest. The relevant thread started here:
https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg05395.html

However meanwhile we will discuss his interleaving implementation, I don't want to block the rest of his work, so I took that patch of (and rebased his work).

I'm spamming all the maintainers of the boards using pflash_cfi02_register(). This series is not 'block' related, it is a classical 'device' model series.
Help reviewing is appreciated :)

I am still looking for real-world code stressing this flash model.

Regards,

Phil.

Philippe Mathieu-Daudé (20):
hw/block/pflash: Simplify trace_pflash_io_read/write() hw/block/pflash: Simplify trace_pflash_data_read/write() hw/block/pflash_cfi02: Fix debug format string hw/block/pflash_cfi02: Add an enum to define the write cycles hw/block/pflash_cfi02: Add helpers to manipulate the status bits hw/block/pflash_cfi02: Simplify a statement using fall through hw/block/pflash_cfi02: Use the ldst API in pflash_write() hw/block/pflash_cfi02: Use the ldst API in pflash_read() hw/block/pflash_cfi02: Extract the pflash_data_read() function hw/block/pflash_cfi02: Unify the MemoryRegionOps tests/pflash-cfi02: Refactor to support testing multiple
configurations
hw/block/pflash_cfi02: Remove pointless local variable hw/block/pflash_cfi02: Document the current CFI values hw/block/pflash_cfi02: Hold the PRI table offset in a variable hw/block/pflash_cfi02: Document 'Page Mode' operations are not
supported
hw/block/pflash_cfi02: Extract pflash_regions_count() hw/block/pflash_cfi02: Split if() condition hw/block/pflash_cfi02: Reduce single byte/word write delay hw/block/pflash_cfi02: Document commands hw/block/pflash_cfi02: Reduce I/O accesses to 16-bit

Stephen Checkoway (8):
tests/pflash-cfi02: Add test for supported CFI commands hw/block/pflash_cfi02: Fix command address comparison hw/block/pflash_cfi02: Implement nonuniform sector sizes hw/block/pflash_cfi02: Fix CFI in autoselect mode hw/block/pflash_cfi02: Fix reset command not ignored during erase hw/block/pflash_cfi02: Implement multi-sector erase hw/block/pflash_cfi02: Implement erase suspend/resume hw/block/pflash_cfi02: Use chip erase time specified in the CFI table

 hw/block/pflash_cfi01.c   |  11 +-
 hw/block/pflash_cfi02.c   | 703 ++++++++++++++++++++++++++------------
 hw/block/trace-events     |  10 +-
 tests/Makefile.include    |   2 +
 tests/pflash-cfi02-test.c | 681 ++++++++++++++++++++++++++++++++++++
 5 files changed, 1173 insertions(+), 234 deletions(-)
 create mode 100644 tests/pflash-cfi02-test.c
Signature · 1 line
2.20.1