Skip to content

nvme-trace: Add support for fabrics command

Minwoo Im linux-nvme 7 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest5 patches 0 repliesNew
  2. v7 RFC7 patches 0 repliesSuperseded
  3. v6 RFC3 patches 0 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v55 patches0 repliesSuperseded
v4 RFC5 patches0 repliesSuperseded
v35 patches1 replySuperseded
v22 patches0 repliesSuperseded

Changes to V7 from the cover letter

- http://lists.infradead.org/pipermail/linux-nvme/2019-June/024818.html
- Add Reviewed-by: tag from Christoph.
- Drop the 3rd commit because command_id is not in __le16.
- Drop the 5th commit, we just can print reserved fields out.
- Few style changes suggested by Christoph.
- Words changes in the comments pointed out by Christoph.

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5nvme: trace: do not EXPORT_SYMBOL for a trace functiondrivers/nvme/host/trace.c+0 -10 replies
2/5nvme: trace: move opcode symbol print to nvme.hdrivers/nvme/host/trace.h include/linux/nvme.h+45 -440 replies
3/5nvme: trace: support for fabrics commands in host-sidedrivers/nvme/host/trace.c drivers/nvme/host/trace.h include/linux/nvme.h+98 -90 replies
4/5nvme: trace: print result and status in hex formatdrivers/nvme/host/trace.h+1 -10 replies
5/5nvmet: introduce target-side tracedrivers/nvme/target/Makefile drivers/nvme/target/core.c drivers/nvme/target/trace.c +1 more+354 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v8 yet.

Read the v8 thread

Cover letter [PATCH V8 0/5] nvme-trace: Add support for fabrics command

Hi Christoph, Hi Sagi.

It's been few days for this series to be reviewed. Please consider it for the nvme-5.3.

This series introduces not only fabrics commands tracing in nvme host side, but also target side tracing features.

Changes to V7:
- http://lists.infradead.org/pipermail/linux-nvme/2019-June/024818.html
- Add Reviewed-by: tag from Christoph.
- Drop the 3rd commit because command_id is not in __le16.
- Drop the 5th commit, we just can print reserved fields out.
- Few style changes suggested by Christoph.
- Words changes in the comments pointed out by Christoph.

Changes to V6:
- Removed the first patch by a suggestion from Christoph. The helper nvmet_req_to_ctrl() has been moved to the last commit which introduces the target-side tracing.
- Symbolic print for the opcodes for admin, nvm, and fabrics have been moved to <linux/nvme.h> to be shared between host and target side. It's just a bunch of macros so that we don't share the actual code as suggested by Christoph.
- Print "device_path" when I/O commands come in and out. The uuid will make the trace line too long so that we just can know the backed device for the request.
- From the 2nd patch to 6th patch, they have been added to this series to make sure the host-side trace supports the exactly same thing with the target-side introduced.

Changes to V5:
- Provide trace code to the target-side instead of a common code shared between host and target to avoid disadvantages something bad for the performance like cache miss. It has been suggested by Christoph.
- Removed the third patch out of this series because that has nothing to do with this series.
- Merged the last two commits into a single commit for the review.

Changes to V4:
- Add Reviewed-by: tag from Sagi. (Thanks to Sagi)
- Consider endianness for cqe->status when assigning the value in trace
- Add more descriptions about the variable arguments in events.

Changes to V3:
- Remove additional argument from the caller level.

Changes to V2:
- Provide a common code for both host and target. (Chaitanya)
- Add support for tracing requests in target-side (Chaitanya)
- Make it simple in trace.h without branch out from nvme core module (Christoph)

Changes to V1:
- fabrics commands should also be decoded, not just showing that it's a fabrics command. (Christoph)
- do not make it within nvme admin commands (Chaitanya)

Minwoo Im (5):
nvme: trace: do not EXPORT_SYMBOL for a trace function
nvme: trace: move opcode symbol print to nvme.h
nvme: trace: support for fabrics commands in host-side
nvme: trace: print result and status in hex format
nvmet: introduce target-side trace

 drivers/nvme/host/trace.c    |  68 +++++++++++-
 drivers/nvme/host/trace.h    |  66 +++---------
 drivers/nvme/target/Makefile |   3 +
 drivers/nvme/target/core.c   |   8 ++
 drivers/nvme/target/trace.c  | 202 +++++++++++++++++++++++++++++++++++
 drivers/nvme/target/trace.h  | 141 ++++++++++++++++++++++++
 include/linux/nvme.h         |  59 ++++++++++
 7 files changed, 495 insertions(+), 52 deletions(-)
 create mode 100644 drivers/nvme/target/trace.c
 create mode 100644 drivers/nvme/target/trace.h
Signature · 1 line
2.21.0