Skip to content

Convert revision.c to parseopt part 1/4

Nguyễn Thái Ngọc Duy git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19revision.h: avoid bit fields in struct rev_inforevision.h+82 -825 replies
2/19revision.h: move repo field downrevision.h+2 -10 replies
3/19revision.c: prepare to convert handle_revision_pseudo_opt()revision.c revision.h+36 -100 replies
4/19rev-parseopt: convert --allrevision.c revision.h+32 -110 replies
5/19rev-parseopt: convert --branchesrevision.c+29 -90 replies
6/19rev-parseopt: convert --bisectrevision.c+21 -70 replies
7/19rev-parseopt: convert --tagsrevision.c+25 -90 replies
8/19rev-parseopt: convert --remotesrevision.c+25 -90 replies
9/19rev-parseopt: convert --globrevision.c+21 -70 replies
10/19rev-parseopt: convert --excluderevision.c+14 -50 replies
11/19rev-parseopt: convert --reflogrevision.c+16 -30 replies
12/19rev-parseopt: convert --indexed-objectsrevision.c+16 -30 replies
13/19rev-parseopt: convert --notrevision.c+15 -30 replies
14/19rev-parseopt: convert --no-walk and --do-walkrevision.c+30 -170 replies
15/19rev-parseopt: convert --single-worktreerevision.c+4 -110 replies
16/19rev-parseopt: prepare to convert handle_revision_opt()Documentation/technical/api-diff.txt diff.c diff.h +2 more+53 -350 replies
17/19rev-parseopt: convert --max-countrevision.c+15 -140 replies
18/19rev-parseopt: convert --skiprevision.c+4 -40 replies
19/19rev-parseopt: convert --min-age and --max-ageparse-options-cb.c parse-options.h revision.c+16 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/19] Convert revision.c to parseopt part 1/4

Following the conversion in diff.c to use parse_options, this time it's revision.c. There are about 76 patches to convert all options, split in 4 parts. After that there are about 10 more to convert rev users to use parse_options() directly.

Full 76 patches are available here [1]. I'm not quite done with those last "10 more" patches yet [2], still stuck at that ancient blame UI. But I should be done by the 76 patches are merged.

[1] https://gitlab.com/pclouds/git/commits/revision-opt-parse-options
[2] https://gitlab.com/pclouds/git/commits/parse-options-step-no-more

Nguyễn Thái Ngọc Duy (19):
revision.h: avoid bit fields in struct rev_info revision.h: move repo field down
revision.c: prepare to convert handle_revision_pseudo_opt()
rev-parseopt: convert --all
rev-parseopt: convert --branches
rev-parseopt: convert --bisect
rev-parseopt: convert --tags
rev-parseopt: convert --remotes
rev-parseopt: convert --glob
rev-parseopt: convert --exclude
rev-parseopt: convert --reflog
rev-parseopt: convert --indexed-objects
rev-parseopt: convert --not
rev-parseopt: convert --no-walk and --do-walk
rev-parseopt: convert --single-worktree
rev-parseopt: prepare to convert handle_revision_opt()
rev-parseopt: convert --max-count
rev-parseopt: convert --skip
rev-parseopt: convert --min-age and --max-age

 Documentation/technical/api-diff.txt |   6 +-
 diff.c                               |  16 -
 diff.h                               |   1 -
 parse-options-cb.c                   |   8 +
 parse-options.h                      |   4 +
 revision.c                           | 465 +++++++++++++++++++--------
 revision.h                           | 172 +++++-----
 7 files changed, 441 insertions(+), 231 deletions(-)
Signature · 1 line
2.21.0.1141.gd54ac2cb17