Skip to content

block: Use bdrv_unref_child() for all children in bdrv_close()

Alberto Garcia qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 6 repliesIn review
  2. v21 patch 1 replySuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2block: Use bdrv_unref_child() for all children in bdrv_close()block.c tests/test-bdrv-drain.c tests/test-bdrv-graph-mod.c+3 -202 replies
2/2block: Make bdrv_root_attach_child() unref child_bs on failureblock.c block/block-backend.c block/quorum.c +1 more+19 -123 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/2] block: Use bdrv_unref_child() for all children in bdrv_close()

Hi,

the first patch is the same as in v2 (with an updated commit message). The second patch is new and makes bdrv_root_attach_child() unref child_bs on failure, as suggested by Max.

Regards,

Berto

v2: https://lists.gnu.org/archive/html/qemu-block/2019-05/msg00325.html
v1: https://lists.gnu.org/archive/html/qemu-block/2019-03/msg01040.html

Alberto Garcia (2):
block: Use bdrv_unref_child() for all children in bdrv_close()
block: Make bdrv_root_attach_child() unref child_bs on failure

 block.c                     | 41 ++++++++++++++++++++---------------------
 block/block-backend.c       |  3 +--
 block/quorum.c              |  1 -
 blockjob.c                  |  2 +-
 tests/test-bdrv-drain.c     |  6 ------
 tests/test-bdrv-graph-mod.c |  1 -
 6 files changed, 22 insertions(+), 32 deletions(-)
Signature · 1 line
2.11.0