Skip to content

send-email: fix cli->config parsing crazyness

Ævar Arnfjörð Bjarmason git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest3 patches 9 repliesIn review

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3send-email: move the read_config() function above getoptsgit-send-email.perl+48 -490 replies
2/3send-email: rename the @bcclist variable for consistencygit-send-email.perl+5 -50 replies
3/3send-email: do defaults -> config -> getopt in that ordergit-send-email.perl t/t9001-send-email.sh+62 -4317 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/3] send-email: fix cli->config parsing crazyness

This is a proposed replacement for Junio's version of the sendemail.transferencoding bugfix. As explained in 3/3 I think the root cause is that we're needlessly doing the config->cli parsing in the wrong order, so let's just fix that.

It fixes the bug at hand, and makes the coge less fragile for future maintenance.

Ævar Arnfjörð Bjarmason (3):
send-email: move the read_config() function above getopts
send-email: rename the @bcclist variable for consistency
send-email: do defaults -> config -> getopt in that order

 git-send-email.perl   | 179 ++++++++++++++++++++++--------------------
 t/t9001-send-email.sh |  13 ++-
 2 files changed, 105 insertions(+), 87 deletions(-)
Signature · 1 line
2.21.0.1020.gf2820cf01a