send-email: fix cli->config parsing crazyness
Get series with b4
b4 am [email protected]Versions newest first
- v3 Latest3 patches 9 repliesIn review
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | send-email: move the read_config() function above getoptsgit-send-email.perl | +48 | 0 replies | |
| 2/3 | send-email: rename the @bcclist variable for consistencygit-send-email.perl | +5 | 0 replies | |
| 3/3 | send-email: do defaults -> config -> getopt in that ordergit-send-email.perl t/ | +62 | 17 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 0/3] send-email: fix cli->config parsing crazyness
This is a proposed replacement for Junio's version of the sendemail.transferencoding bugfix. As explained in 3/3 I think the root cause is that we're needlessly doing the config->cli parsing in the wrong order, so let's just fix that.
It fixes the bug at hand, and makes the coge less fragile for future maintenance.
Ævar Arnfjörð Bjarmason (3):
send-email: move the read_config() function above getopts
send-email: rename the @bcclist variable for consistency
send-email: do defaults -> config -> getopt in that order
git-send-email.perl | 179 ++++++++++++++++++++++-------------------- t/t9001-send-email.sh | 13 ++- 2 files changed, 105 insertions(+), 87 deletions(-)
Signature · 1 line
2.21.0.1020.gf2820cf01a