rtlwifi: 8192de: Fix used uninitialized variables in power tracking
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | rtlwifi: 8192de: Reduce indentation and fix coding styledrivers/ | +303 | 1 reply | |
| 2/4 | rtlwifi: 8192de: make tables to be 'static const'drivers/ | +4 | 0 replies | |
| 3/4 | rtlwifi: 8192de: Fix used uninitialized variables in power trackingdrivers/ | +9 | 0 replies | |
| 4/4 | rtlwifi: 8192de: use le32 to access cckswing tablesdrivers/ | +14 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] rtlwifi: 8192de: Fix used uninitialized variables in power tracking
From: Ping-Ke Shih <[email protected]>
This issue is found by Coverity and repoerted by Colin Ian King. An array ofdm_index[3] is never initialized.
In order to fix this issue, I refactor the code to be more readable, and then I investigate the variable ofdm_index[] should be initialized as the index corresponding to thermal value programmed in efuse.
The cckswing table in the last patch is used to adjust TX power. When I check this function, the table is in little-endian order, but compare with register value in cpu order. Then, fix it as well.
Ping-Ke Shih (4):
rtlwifi: 8192de: Reduce indentation and fix coding style
rtlwifi: 8192de: make tables to be 'static const'
rtlwifi: 8192de: Fix used uninitialized variables in power tracking
rtlwifi: 8192de: use le32 to access cckswing tables
.../wireless/realtek/rtlwifi/rtl8192de/dm.c | 695 +++++++++--------- 1 file changed, 330 insertions(+), 365 deletions(-)
Signature · 1 line
2.21.0