Skip to content

Fix a bug and avoid dangerous usage patterns

Vladimir Oltean netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net: dsa: Initialize DSA_SKB_CB(skb)->deferred_xmit variableinclude/net/dsa.h net/dsa/slave.c+2 -30 replies
2/3net: dsa: Remove dangerous DSA_SKB_CLONE() macroinclude/net/dsa.h+0 -91 reply
3/3net: dsa: Remove the now unused DSA_SKB_CB_COPY() macroinclude/net/dsa.h+0 -31 reply

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchAndrew Lunn
1/3
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net 0/3] Fix a bug and avoid dangerous usage patterns

Making DSA use the sk_buff control block was my idea during the 'Traffic-support-for-SJA1105-DSA-driver' patchset, and I had also introduced a series of macro helpers that turned out to not be so helpful:

1. DSA_SKB_ZERO() zeroizes the 48-byte skb->cb area, but due to the high performance impact in the hotpath it was only intended to be called from the timestamping path. But it turns out that not zeroizing it has uncovered the reading of an uninitialized member field of DSA_SKB_CB, so in the future just be careful about what needs initialization and remove this macro.
2. DSA_SKB_CLONE() contains a flaw in its body definition (originally put there to silence checkpatch.pl) and is unusable at this point (will only cause NPE's when used). So remove it.
3. For DSA_SKB_COPY() the same performance considerations apply as above and therefore it's best to prune this function before it reaches a stable kernel and potentially any users.

Vladimir Oltean (3):
net: dsa: Initialize DSA_SKB_CB(skb)->deferred_xmit variable
net: dsa: Remove dangerous DSA_SKB_CLONE() macro
net: dsa: Remove the now unused DSA_SKB_CB_COPY() macro

 include/net/dsa.h | 15 ---------------
 net/dsa/slave.c   |  2 ++
 2 files changed, 2 insertions(+), 15 deletions(-)
Signature · 1 line
2.17.1