Skip to content

target/arm/kvm: enable SVE in guests

Andrew Jones qemu-arm qemu-devel 8 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest9 patches 0 repliesNew
  2. v79 patches 6 repliesApplied
  3. v69 patches 25 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v59 patches22 repliesSuperseded
v49 patches22 repliesSuperseded
v315 patches14 repliesSuperseded
v214 patches80 repliesSuperseded
v113 patches57 repliesSuperseded

Changes in v8 from the cover letter

- Fixed another issue with the new make check tests. We weren't detecting kvm in a way that worked when running a cross-compiled aarch32 qemu on an aarch64 machine that had kvm. So now we detect kvm in a new, more robust way using the query-kvm qmp command. Besides some context changes after rebase, all the changes for this version are in 2/9, so I left all tags as they were.

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9target/arm/monitor: Introduce qmp_query_cpu_model_expansiondocs/arm-cpu-features.rst qapi/machine-target.json target/arm/monitor.c+286 -30 replies
2/9tests: arm: Introduce cpu feature teststests/Makefile.include tests/arm-cpu-features.c+257 -10 replies
3/9target/arm: Allow SVE to be disabled via a CPU propertytarget/arm/cpu.c target/arm/cpu64.c target/arm/monitor.c +1 more+49 -90 replies
4/9target/arm/cpu64: max cpu: Introduce sve<N> propertiesdocs/arm-cpu-features.rst include/qemu/bitops.h target/arm/cpu.c +5 more+606 -90 replies
5/9target/arm/kvm64: Add kvm_arch_get/put_svetarget/arm/kvm64.c+155 -280 replies
6/9target/arm/kvm64: max cpu: Enable SVE when availabletarget/arm/cpu64.c target/arm/kvm.c target/arm/kvm64.c +2 more+69 -40 replies
7/9target/arm/kvm: scratch vcpu: Preserve input kvm_vcpu_init featurestarget/arm/kvm.c target/arm/kvm32.c target/arm/kvm64.c+25 -70 replies
8/9target/arm/cpu64: max cpu: Support sve properties with KVMdocs/arm-cpu-features.rst target/arm/cpu64.c target/arm/kvm64.c +2 more+377 -560 replies
9/9target/arm/kvm: host cpu: Add support for sve<N> propertiesdocs/arm-cpu-features.rst target/arm/cpu.c target/arm/cpu.h +3 more+55 -330 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchRichard HendersonEric AugerBeata MichalskaMasayoshi Mizuma
1/9R-b R-b R-b
2/9R-b
3/9R-b R-b R-b T-b
4/9R-b R-b R-b T-b
5/9R-b R-b T-b
6/9R-b R-b R-b T-b
7/9R-b R-b R-b T-b
8/9R-b R-b T-b
9/9R-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v8 thread

Cover letter [PATCH v8 0/9] target/arm/kvm: enable SVE in guests

Since Linux kernel v5.2-rc1 KVM has support for enabling SVE in guests. This series provides the QEMU bits for that enablement. First, we select existing CPU properties representing features we want to advertise in addition to the SVE vector lengths and prepare them for a qmp query. Then we introduce the qmp query, applying it immediately to those selected features. We also document ARM CPU features at this time. We next add a qtest for the selected CPU features that uses the qmp query for its tests - and we continue to add tests as we add CPU features with the following patches. So then, once we have the support we need for CPU feature querying and testing, we add our first SVE CPU feature property, 'sve', which just allows SVE to be completely enabled/disabled. Following that feature property, we add all 16 vector length properties along with the input validation they need and tests to prove the validation works. At this point the SVE features are still only for TCG, so we provide some patches to prepare for KVM and then a patch that allows the 'max' CPU type to enable SVE with KVM, but at first without vector length properties. After a bit more preparation we add the SVE vector length properties to the KVM-enabled 'max' CPU type along with the additional input validation and tests that that needs. Finally we allow the 'host' CPU type to also enjoy these properties by simply sharing them with it.

v8:
- Fixed another issue with the new make check tests. We weren't detecting kvm in a way that worked when running a cross-compiled aarch32 qemu on an aarch64 machine that had kvm. So now we detect kvm in a new, more robust way using the query-kvm qmp command. Besides some context changes after rebase, all the changes for this version are in 2/9, so I left all tags as they were.

v7:
- Fixed kvm32 tests and added a couple
- Picked up r-b's from Beata and t-b's from Masa

v6:
- Adding missing visit_free() to an error path in qmp_query_cpu_model_expansion() in patch 1/9.
- Rebased on latest master (applied cleanly)
- Picked up r-b's from Richard and Eric

v5:
- Now generate an error if vector lengths have been explicitly enabled, but SVE is disabled
- Fixed a bug in sve_zcr_len_for_el()
- Fixed a bug in kvm_arch_put/get_sve() and brought back the put/get of FPSR/FPCR
- A few document clarifications and added some new sentences
- Added a couple more tests
- Added BIT_ULL and use it in the test
- Removed an unnecessary bitmap search
- Moved a cpu_max_get_sve_max_vq() hunk from 4/9 to 3/9 and added a fix for it in 8/9
- Picked up some more tags from Eric

v4:
- Integrated Richard Henderson's rework for the sve property validation, in order to do all validating at finalize time and save several lines of code.
- Fixed 'host' cpu SVE default. It was still off by default.
- Cleaned up #ifdef's for sve_bswap64()
- Removed redundant KVM_CAP_ARM_SVE extension check in

    kvm_arm_sve_get_vls()

- Improved the KVM SVE qtest
- Renamed sve<vl-bits> to sve<N> everywhere
- Renamed power-of-2 to power-of-two everywhere
- Picked up some more tags from Richard

Thanks!
drew

Andrew Jones (9):
target/arm/monitor: Introduce qmp_query_cpu_model_expansion
tests: arm: Introduce cpu feature tests
target/arm: Allow SVE to be disabled via a CPU property target/arm/cpu64: max cpu: Introduce sve<N> properties target/arm/kvm64: Add kvm_arch_get/put_sve target/arm/kvm64: max cpu: Enable SVE when available target/arm/kvm: scratch vcpu: Preserve input kvm_vcpu_init features target/arm/cpu64: max cpu: Support sve properties with KVM target/arm/kvm: host cpu: Add support for sve<N> properties

 docs/arm-cpu-features.rst | 317 ++++++++++++++++++++++
 include/qemu/bitops.h     |   1 +
 qapi/machine-target.json  |   6 +-
 target/arm/cpu.c          |  25 +-
 target/arm/cpu.h          |  21 ++
 target/arm/cpu64.c        | 356 ++++++++++++++++++++++++-
 target/arm/helper.c       |  10 +-
 target/arm/kvm.c          |  25 +-
 target/arm/kvm32.c        |   6 +-
 target/arm/kvm64.c        | 323 ++++++++++++++++++++---
 target/arm/kvm_arm.h      |  39 +++
 target/arm/monitor.c      | 158 +++++++++++
 tests/Makefile.include    |   5 +-
 tests/arm-cpu-features.c  | 540 ++++++++++++++++++++++++++++++++++++++
 14 files changed, 1775 insertions(+), 57 deletions(-)
 create mode 100644 docs/arm-cpu-features.rst
 create mode 100644 tests/arm-cpu-features.c
Signature · 37 lines
2.21.0



*** BLURB HERE ***

Andrew Jones (9):
  target/arm/monitor: Introduce qmp_query_cpu_model_expansion
  tests: arm: Introduce cpu feature tests
  target/arm: Allow SVE to be disabled via a CPU property
  target/arm/cpu64: max cpu: Introduce sve<N> properties
  target/arm/kvm64: Add kvm_arch_get/put_sve
  target/arm/kvm64: max cpu: Enable SVE when available
  target/arm/kvm: scratch vcpu: Preserve input kvm_vcpu_init features
  target/arm/cpu64: max cpu: Support sve properties with KVM
  target/arm/kvm: host cpu: Add support for sve<N> properties

 docs/arm-cpu-features.rst | 317 ++++++++++++++++++++++
 include/qemu/bitops.h     |   1 +
 qapi/machine-target.json  |   6 +-
 target/arm/cpu.c          |  25 +-
 target/arm/cpu.h          |  21 ++
 target/arm/cpu64.c        | 356 +++++++++++++++++++++++-
 target/arm/helper.c       |  10 +-
 target/arm/kvm.c          |  25 +-
 target/arm/kvm32.c        |   6 +-
 target/arm/kvm64.c        | 323 +++++++++++++++++++---
 target/arm/kvm_arm.h      |  39 +++
 target/arm/monitor.c      | 158 +++++++++++
 tests/Makefile.include    |   5 +-
 tests/arm-cpu-features.c  | 551 ++++++++++++++++++++++++++++++++++++++
 14 files changed, 1786 insertions(+), 57 deletions(-)
 create mode 100644 docs/arm-cpu-features.rst
 create mode 100644 tests/arm-cpu-features.c

-- 
2.21.0