Skip to content

RFC hw/acpi: make build_madt arch agnostic

Wei Yang qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest9 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9hw/acpi: expand pc_madt_cpu_entry in placehw/acpi/cpu.c hw/acpi/piix4.c hw/i386/acpi-build.c +2 more+59 -530 replies
2/9hw/acpi: implement madt_sub[ACPI_APIC_PROCESSOR]hw/acpi/cpu.c hw/acpi/piix4.c hw/i386/acpi-build.c +3 more+38 -240 replies
3/9hw/acpi: implement madt_sub[ACPI_APIC_LOCAL_X2APIC]hw/acpi/cpu.c hw/i386/acpi-build.c+23 -240 replies
4/9hw/acpi: implement madt_sub[ACPI_APIC_IO]hw/i386/acpi-build.c+14 -70 replies
5/9hw/acpi: implement madt_sub[ACPI_APIC_XRUPT_OVERRIDE]hw/i386/acpi-build.c+24 -130 replies
6/9hw/acpi: implement madt_sub[ACPI_APIC_LOCAL_X2APIC_NMI]hw/i386/acpi-build.c+14 -80 replies
7/9hw/acpi: implement madt_sub[ACPI_APIC_LOCAL_NMI]hw/i386/acpi-build.c+14 -80 replies
8/9hw/acpi: factor build_madt with madt_inputhw/i386/acpi-build.c+65 -380 replies
9/9hw/acpi: implement madt_main to manipulate main madt tablehw/acpi/piix4.c hw/i386/acpi-build.c hw/isa/lpc_ich9.c +2 more+15 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [RFC PATCH 0/9] hw/acpi: make build_madt arch agnostic

Now MADT is highly depend in architecture and machine type and leaves duplicated code in different architecture. The series here tries to generalize it.

MADT contains one main table and several sub tables. These sub tables are highly related to architecture. Here we introduce one method to make it architecture agnostic.

* each architecture define its sub-table implementation function in madt_sub
* introduces struct madt_input to collect sub table information and pass to build_madt

By doing so, each architecture could prepare its own sub-table implementation and madt_input. And keep build_madt architecture agnostic.

Wei Yang (9):
hw/acpi: expand pc_madt_cpu_entry in place hw/acpi: implement madt_sub[ACPI_APIC_PROCESSOR] hw/acpi: implement madt_sub[ACPI_APIC_LOCAL_X2APIC] hw/acpi: implement madt_sub[ACPI_APIC_IO] hw/acpi: implement madt_sub[ACPI_APIC_XRUPT_OVERRIDE] hw/acpi: implement madt_sub[ACPI_APIC_LOCAL_X2APIC_NMI] hw/acpi: implement madt_sub[ACPI_APIC_LOCAL_NMI] hw/acpi: factor build_madt with madt_input hw/acpi: implement madt_main to manipulate main madt table

 hw/acpi/cpu.c                        |  14 +-
 hw/acpi/piix4.c                      |   3 +-
 hw/i386/acpi-build.c                 | 265 +++++++++++++++++----------
 hw/isa/lpc_ich9.c                    |   3 +-
 include/hw/acpi/acpi_dev_interface.h |  12 +-
 include/hw/i386/pc.h                 |   2 +
 6 files changed, 194 insertions(+), 105 deletions(-)
Signature · 1 line
2.19.1