Skip to content

NFC: nxp-nci: clean up and support new ID

Andy Shevchenko linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest12 patches 20 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12NFC: nxp-nci: Add NXP1001 to the ACPI ID tabledrivers/nfc/nxp-nci/i2c.c+1 -00 replies
2/12NFC: nxp-nci: Get rid of platform dataMAINTAINERS drivers/nfc/nxp-nci/core.c drivers/nfc/nxp-nci/i2c.c +2 more+1 -380 replies
3/12NFC: nxp-nci: Convert to use GPIO descriptordrivers/nfc/nxp-nci/core.c drivers/nfc/nxp-nci/i2c.c+15 -460 replies
4/12NFC: nxp-nci: Add GPIO ACPI mapping tabledrivers/nfc/nxp-nci/i2c.c+16 -20 replies
5/12NFC: nxp-nci: Get rid of code duplication in ->probe()drivers/nfc/nxp-nci/i2c.c+15 -530 replies
6/12NFC: nxp-nci: Get rid of useless labeldrivers/nfc/nxp-nci/i2c.c+4 -80 replies
7/12NFC: nxp-nci: Constify acpi_device_iddrivers/nfc/nxp-nci/i2c.c+1 -10 replies
8/12NFC: nxp-nci: Drop of_match_ptr() usedrivers/nfc/nxp-nci/i2c.c+1 -10 replies
9/12NFC: nxp-nci: Drop comma in terminator linesdrivers/nfc/nxp-nci/i2c.c+2 -20 replies
10/12NFC: nxp-nci: Remove unused macro pr_fmt()drivers/nfc/nxp-nci/i2c.c+0 -20 replies
11/12NFC: nxp-nci: Remove 'default n' for testsdrivers/nfc/nxp-nci/Kconfig+0 -10 replies
12/12NFC: nxp-nci: Convert to SPDX license tagsdrivers/nfc/nxp-nci/core.c drivers/nfc/nxp-nci/firmware.c drivers/nfc/nxp-nci/i2c.c+3 -360 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/12] NFC: nxp-nci: clean up and support new ID

It has been reported that some laptops, equipped with NXP NFC300, have different ID then mentioned in the driver.

While at it, I found that the driver has a lot of duplication and redundant platform data. The rest of the series (11 out of 12 patches) is dedicated to clean the driver up.

Sedat, would be nice if you can compile kernel with this patch series applied and test on your laptop.

In v2:
- added new ID patch
- added new clean up patch
- Cc'ed to linux-wireless@ as well, since linux-nfc@ bounces my mails
- Cc'ed to the reported of the problem with T470 laptop

Andy Shevchenko (12):
NFC: nxp-nci: Add NXP1001 to the ACPI ID table
NFC: nxp-nci: Get rid of platform data
NFC: nxp-nci: Convert to use GPIO descriptor
NFC: nxp-nci: Add GPIO ACPI mapping table
NFC: nxp-nci: Get rid of code duplication in ->probe()
NFC: nxp-nci: Get rid of useless label
NFC: nxp-nci: Constify acpi_device_id
NFC: nxp-nci: Drop of_match_ptr() use
NFC: nxp-nci: Drop comma in terminator lines
NFC: nxp-nci: Remove unused macro pr_fmt()
NFC: nxp-nci: Remove 'default n' for tests
NFC: nxp-nci: Convert to SPDX license tags

 MAINTAINERS                           |   1 -
 drivers/nfc/nxp-nci/Kconfig           |   1 -
 drivers/nfc/nxp-nci/core.c            |  15 +--
 drivers/nfc/nxp-nci/firmware.c        |  13 +--
 drivers/nfc/nxp-nci/i2c.c             | 147 ++++++--------------------
 drivers/nfc/nxp-nci/nxp-nci.h         |   1 -
 include/linux/platform_data/nxp-nci.h |  27 -----
 7 files changed, 37 insertions(+), 168 deletions(-)
 delete mode 100644 include/linux/platform_data/nxp-nci.h
Signature · 1 line
2.20.1