Skip to content

ext2: Cleanup ext2_xattr_set()

Jan Kara linux-ext4 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v13 patches 4 repliesSuperseded

Changes in v2 from the cover letter

* fixed patch 2 to maintain sorting of xattrs in ext2_xattr_set
* made loops in ext2_xattr_get() and ext2_xattr_list() also check all seen xattr entries

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ext2: introduce helper for xattr entry validationfs/ext2/xattr.c+21 -110 replies
2/3ext2: Merge loops in ext2_xattr_set()fs/ext2/xattr.c+19 -221 reply
3/3ext2: Strengthen xattr block checksfs/ext2/xattr.c+10 -121 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchAndreas DilgerChengguang Xu
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH 0/3 v2] ext2: Cleanup ext2_xattr_set()

Hello,

this series contains updated patch from Chengguang and two additional cleanups to xattr code in ext2_xattr_set() to remove some duplicated code and useless checks.

Changes since v1:
* fixed patch 2 to maintain sorting of xattrs in ext2_xattr_set
* made loops in ext2_xattr_get() and ext2_xattr_list() also check all seen xattr entries

Honza