Skip to content

Get rid of global_qtest in q35-, qom-, numa- and more tests

Thomas Huth qemu-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6tests/libqos: Get rid of global_qtest dependency in qvring_init()tests/libqos/virtio-mmio.c tests/libqos/virtio-pci.c tests/libqos/virtio.c +1 more+15 -110 replies
2/6tests/q35-test: Make test independent of global_qtesttests/q35-test.c+18 -210 replies
3/6tests/numa-test: Use qtest_init() instead of qtest_start()tests/numa-test.c+30 -230 replies
4/6tests/qom-test: Use qtest_init() instead of qtest_start()tests/qom-test.c+13 -150 replies
5/6tests/device-introspect: Use qtest_init() instead of qtest_start()tests/device-introspect-test.c+46 -390 replies
6/6tests/hd-geo-test: Use qtest_init() instead of qtest_start()tests/hd-geo-test.c+41 -350 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/6] Get rid of global_qtest in q35-, qom-, numa- and more tests

Here are some more patches that get rid of global_qtest and related functions in some of the qtests (hacked along the way while waiting for other compilation and test processes to finish). A global variable like global_qtest is very problematic in tests that track multiple test states (like migration tests). But since we often share code between tests, it is better to avoid these global_qtest related functions completely - i.e. the plan is to get rid of global_qtest completely in the long run.

Thomas Huth (6):
tests/libqos: Get rid of global_qtest dependency in qvring_init() tests/q35-test: Make test independent of global_qtest tests/numa-test: Use qtest_init() instead of qtest_start() tests/qom-test: Use qtest_init() instead of qtest_start() tests/device-introspect: Use qtest_init() instead of qtest_start() tests/hd-geo-test: Use qtest_init() instead of qtest_start()

 tests/device-introspect-test.c | 85 ++++++++++++++++++----------------
 tests/hd-geo-test.c            | 76 ++++++++++++++++--------------
 tests/libqos/virtio-mmio.c     |  2 +-
 tests/libqos/virtio-pci.c      |  3 +-
 tests/libqos/virtio.c          | 18 +++----
 tests/libqos/virtio.h          |  3 +-
 tests/numa-test.c              | 53 ++++++++++++---------
 tests/q35-test.c               | 39 +++++++---------
 tests/qom-test.c               | 28 ++++++-----
 9 files changed, 163 insertions(+), 144 deletions(-)
Signature · 1 line
2.21.0