Skip to content

ether: improvements and optimizations

Stephen Hemminger dpdk-dev 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest11 patches 5 repliesIn review
  2. v811 patches 0 repliesSuperseded
  3. v712 patches 10 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v68 patches3 repliesSuperseded
v58 patches7 repliesSuperseded
v48 patches9 repliesSuperseded
v36 patches9 repliesSuperseded
v27 patches5 repliesSuperseded

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11net/ether: deinline non-critical functionsdrivers/net/axgbe/Makefile drivers/net/memif/Makefile drivers/net/octeontx2/Makefile +5 more+45 -250 replies
2/11net/ether: add function to convert string to ethernet addresslib/librte_net/rte_ether.c lib/librte_net/rte_ether.h lib/librte_net/rte_net_version.map+64 -00 replies
3/11ethdev: use new ethernet parsing functionlib/Makefile lib/librte_ethdev/Makefile lib/librte_ethdev/meson.build +1 more+3 -110 replies
4/11net/ether: use bitops to speedup comparisonlib/librte_net/rte_ether.h+7 -100 replies
5/11cmdline: use new ethernet address parserlib/Makefile lib/librte_cmdline/Makefile lib/librte_cmdline/cmdline_parse_etheraddr.c +2 more+15 -690 replies
6/11net/bonding: use new ethernet address parserdrivers/net/bonding/Makefile drivers/net/bonding/meson.build drivers/net/bonding/rte_eth_bond_args.c+3 -70 replies
7/11app/testpmd: use new ethernet address parserapp/test-pmd/cmdline_flow.c app/test-pmd/config.c app/test-pmd/parameters.c+8 -223 replies
8/11net/virtio: use new ether addr parsingdrivers/net/virtio/virtio_user/virtio_user_dev.c+3 -70 replies
9/11net/failsafe: use common ether address parsing routinedrivers/net/failsafe/failsafe_args.c+2 -60 replies
10/11net/vdev_netvsc: use common ethernet address parsingdrivers/net/vdev_netvsc/vdev_netvsc.c+1 -90 replies
11/11net/memif: use common ethernet address parsing routinedrivers/net/memif/rte_eth_memif.c+1 -60 replies

Reviews trailers per patch

7 of 11 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRami RosenAndrew RybchenkoOlivier MatzBernard IremongerGaetan RivetMatan AzradFerruh Yigit
SeriesR-b
1/11A-b R-b A-b
2/11R-b
3/11
4/11R-b A-b
5/11A-b
6/11
7/11A-b
8/11
9/11A-b
10/11A-b
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v9 thread

Cover letter [dpdk-dev] [PATCH v9 00/11] ether: improvements and optimizations

This is a collection of patches around the ethernet address manipulation routines in librte_net/rte_ether.

v9
add missing librte_net for new octoeonx2
v8
set rte_errno in rte_eth_unformat_addr
drop ether_address alignment patch. Bruce can handle deprecation and sending the patches later
v7
use rte_ether_unformat_addr in more drivers
v6
add librte_net to axgbe and memif Makefile
v5
reword commit messages to workaround check-log complaints
v4
fix meson build
reword commit messages
add bonding and tespmd patches
v3
rebase to use rte_ether prefix
drop aligning ethernet headers for now.

Stephen Hemminger (11):
net/ether: deinline non-critical functions net/ether: add function to convert string to ethernet address
ethdev: use new ethernet parsing function net/ether: use bitops to speedup comparison
cmdline: use new ethernet address parser net/bonding: use new ethernet address parser app/testpmd: use new ethernet address parser net/virtio: use new ether addr parsing net/failsafe: use common ether address parsing routine net/vdev_netvsc: use common ethernet address parsing net/memif: use common ethernet address parsing routine

 app/test-pmd/cmdline_flow.c                   |  5 +-
 app/test-pmd/config.c                         | 10 +--
 app/test-pmd/parameters.c                     | 15 +---
 drivers/net/axgbe/Makefile                    |  2 +-
 drivers/net/bonding/Makefile                  |  2 +-
 drivers/net/bonding/meson.build               |  2 +-
 drivers/net/bonding/rte_eth_bond_args.c       |  6 +-
 drivers/net/failsafe/failsafe_args.c          |  8 +-
 drivers/net/memif/Makefile                    |  2 +-
 drivers/net/memif/rte_eth_memif.c             |  7 +-
 drivers/net/octeontx2/Makefile                |  2 +-
 drivers/net/vdev_netvsc/vdev_netvsc.c         | 10 +--
 .../net/virtio/virtio_user/virtio_user_dev.c  | 10 +--
 lib/Makefile                                  |  3 +-
 lib/librte_cmdline/Makefile                   |  3 +-
 lib/librte_cmdline/cmdline_parse_etheraddr.c  | 71 ++---------------
 lib/librte_cmdline/meson.build                |  6 +-
 lib/librte_ethdev/Makefile                    |  2 +-
 lib/librte_ethdev/meson.build                 |  2 +-
 lib/librte_ethdev/rte_class_eth.c             |  9 +--
 lib/librte_net/Makefile                       |  1 +
 lib/librte_net/meson.build                    |  2 +-
 lib/librte_net/rte_ether.c                    | 78 +++++++++++++++++++
 lib/librte_net/rte_ether.h                    | 54 ++++++-------
 lib/librte_net/rte_net_version.map            |  8 ++
 lib/meson.build                               |  2 +-
 26 files changed, 151 insertions(+), 171 deletions(-)
 create mode 100644 lib/librte_net/rte_ether.c
Signature · 1 line
2.20.1