Skip to content

Fix LED GPIO trigger behavior

Kun Yi linux-gpio linux-leds lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ledtrig-gpio: Request user input pin as GPIOdrivers/leds/trigger/ledtrig-gpio.c+25 -61 reply
2/2ledtrig-gpio: 0 is a valid GPIO numberdrivers/leds/trigger/ledtrig-gpio.c+5 -111 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Fix LED GPIO trigger behavior

*** BLURB HERE ***
Hello there,

I recently tested ledtrig-gpio on an embedded controller and one of the issues I had involve not requesting the user input pin as GPIO.

In many embedded systems, a pin could be muxed as several functions, and requesting the pin as GPIO is necessary to let pinmux select the pin as a GPIO instead of, say an I2C pin. I'd like to learn whether it is appropriate to assume user of ledtrig-gpio really intends to use GPIOs and not some weird pins that are used as other functions.

Kun Yi (2):
ledtrig-gpio: Request user input pin as GPIO
ledtrig-gpio: 0 is a valid GPIO number

 drivers/leds/trigger/ledtrig-gpio.c | 35 ++++++++++++++++++++---------
 1 file changed, 24 insertions(+), 11 deletions(-)
Signature · 1 line
2.21.0.1020.gf2820cf01a-goog