iotests: Selfish patches
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest7 patches 13 repliesIn review
- v38 patches 28 repliesSuperseded
- v25 patches 3 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 4 patches | 4 replies | Superseded |
Changes in v4 from the cover letter
- I merged the old patch 1 in the meantime
- Patch 2: Adjusted the comment to make it more clear that it is case_notrun() itself that will not skip the test case, as requested by Andrey (I hope it fits what he had in mind, more or less); kept the R-bs, because I somehow feel like that’s the right thing to do here.
- Patch 3: The func_wrapper returned by the skip_test_decorator has a mandatory argument; make that and its required type explicit (with an annotation), as suggested by John
(Kevin made me aware of the fact that annotations exist since Python 3.0, it’s just that they didn’t mean anything back then (neither do they really now, but whatever, it’s better than a comment))
- Patch 4: Resolved a conflict because of the change to patch 3
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | iotests: Prefer null-co over null-aiotests/ tests/ | +4 | 1 reply | |
| 2/7 | iotests: Allow skipping test casestests/ | +19 | 0 replies | |
| 3/7 | iotests: Use case_skip() in skip_if_unsupported()tests/ | +4 | 2 replies | |
| 4/7 | iotests: Let skip_if_unsupported accept a functiontests/ | +6 | 1 reply | |
| 5/7 | iotests: Test driver whitelisting in 093tests/ | +9 | 4 replies | |
| 6/7 | iotests: Test driver whitelisting in 136tests/ | +10 | 2 replies | |
| 7/7 | iotests: Cache supported_formats()tests/ | +11 | 1 reply |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | John Snow | Andrey Shinkevich | Thomas Huth |
|---|---|---|---|
| 1/7 | R-b | R-b | R-b |
| 2/7 | R-b | R-b | |
| 3/7 | R-b | R-b | |
| 4/7 | R-b | ||
| 5/7 | R-b | R-b | |
| 6/7 | R-b | R-b | |
| 7/7 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [Qemu-devel] [PATCH v4 0/7] iotests: Selfish patches
Hi,
Again, let me start with a link to an actually explanatory cover letter:
https://lists.nongnu.org/archive/html/qemu-block/2019-06/msg01102.html
v3:
https://lists.nongnu.org/archive/html/qemu-block/2019-08/msg00950.html
v4:
- I merged the old patch 1 in the meantime
- Patch 2: Adjusted the comment to make it more clear that it is case_notrun() itself that will not skip the test case, as requested by Andrey (I hope it fits what he had in mind, more or less); kept the R-bs, because I somehow feel like that’s the right thing to do here.
- Patch 3: The func_wrapper returned by the skip_test_decorator has a mandatory argument; make that and its required type explicit (with an annotation), as suggested by John
(Kevin made me aware of the fact that annotations exist since Python 3.0, it’s just that they didn’t mean anything back then (neither do they really now, but whatever, it’s better than a comment))
- Patch 4: Resolved a conflict because of the change to patch 3
git-backport-diff against v3:
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/7:[----] [--] 'iotests: Prefer null-co over null-aio' 002/7:[0007] [FC] 'iotests: Allow skipping test cases' 003/7:[0008] [FC] 'iotests: Use case_skip() in skip_if_unsupported()' 004/7:[0002] [FC] 'iotests: Let skip_if_unsupported() accept a method' 005/7:[----] [--] 'iotests: Test driver whitelisting in 093' 006/7:[----] [--] 'iotests: Test driver whitelisting in 136' 007/7:[----] [--] 'iotests: Cache supported_formats()'
Max Reitz (7):
iotests: Prefer null-co over null-aio
iotests: Allow skipping test cases
iotests: Use case_skip() in skip_if_unsupported()
iotests: Let skip_if_unsupported accept a function
iotests: Test driver whitelisting in 093
iotests: Test driver whitelisting in 136
iotests: Cache supported_formats()
tests/qemu-iotests/093 | 19 ++++++++----- tests/qemu-iotests/136 | 14 +++++++--- tests/qemu-iotests/245 | 2 +- tests/qemu-iotests/iotests.py | 52 +++++++++++++++++++++++++++-------- 4 files changed, 63 insertions(+), 24 deletions(-)
Signature · 1 line
2.21.0