Skip to content

RFC Fix return value checks for posix apis

Sandeep Patil ltp 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest1 patch 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1open_posix_testsuite/pthread_sigmask: fix return value checkstestcases/open_posix_testsuite/conformance/interfaces/pthread_sigmask/6-1.c+40 -291 reply
1/1open_posix_testsuite/pthread_sigmask: fix return value checks+0 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [LTP] [RFC PATCH 0/1] Fix return value checks for posix apis

This is an RFC patch to demonstrate that most of the pthread_* calls in the open_posix_testsuite seem to be doing the return value checks incorrectly. Most posix_* apis return positive errno on failure and 0 on success.

PATCH 1/1 demonstrates the fixes needed for pthread_sigmask/6-1 for example. This pattern is fairly widespread in open_posix_testsuite.

After going through the documentation in the project, I wasn't sure if I tested this correctly. After building, I tried the following

$ cd testcases/open_posix_testsuite
$ ./bin/run_tesit.sh conformance/interfaces/pthread_sigmask pthread_sigmask_6-1.run-test

...and that keeps running into test being skipped due to missing file. (I do have pthread_sigmask_6-1.run-test in place).

So, consider this build tested only for now. I'd love to know how we can test this and if we are still using the testsuite, then I am happy to fix rest of the places where its broken.

Sandeep Patil (1):
open_posix_testsuite/pthread_sigmask: fix return value checks

 .../interfaces/pthread_sigmask/6-1.c          | 69 +++++++++++--------
 1 file changed, 40 insertions(+), 29 deletions(-)
Signature · 1 line
2.21.0.1020.gf2820cf01a-goog