Skip to content

clk: sunxi-ng: clk parent rewrite part 1

Chen-Yu Tsai linux-arm-kernel linux-clk lkml 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest25 patches 0 repliesNew
  2. v125 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- Collected Maxime's Acked-by for sunxi patches
- Expanded possible_parents_show() to cover most cases
- Added comment to CLK_HW_INIT_HWS detailing usage for sharing compound literal

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/25clk: Fix debugfs clk_possible_parents for clks without parent string namesdrivers/clk/clk.c+41 -30 replies
2/25clk: Add CLK_HW_INIT_* macros using .parent_hwsinclude/linux/clk-provider.h+32 -00 replies
3/25clk: Add CLK_HW_INIT_FW_NAME macro using .fw_name in .parent_datainclude/linux/clk-provider.h+11 -00 replies
4/25clk: Add CLK_HW_INIT_PARENT_DATA macro using .parent_datainclude/linux/clk-provider.h+9 -00 replies
5/25clk: fixed-factor: Add CLK_FIXED_FACTOR_HW which takes clk_hw pointer as parentinclude/linux/clk-provider.h+11 -00 replies
6/25clk: fixed-factor: Add CLK_FIXED_FACTOR_HWS which takes list of struct clk_hw *include/linux/clk-provider.h+15 -00 replies
7/25clk: fixed-factor: Add CLK_FIXED_FACTOR_FW_NAME for DT clock-names parentinclude/linux/clk-provider.h+11 -00 replies
8/25clk: sunxi-ng: switch to of_clk_hw_register() for registering clksdrivers/clk/sunxi-ng/ccu_common.c+1 -10 replies
9/25clk: sunxi-ng: sun8i-r: Use local parent references for CLK_HW_INIT_*drivers/clk/sunxi-ng/ccu-sun8i-r.c+25 -400 replies
10/25clk: sunxi-ng: a10: Use local parent references for CLK_FIXED_FACTORdrivers/clk/sunxi-ng/ccu-sun4i-a10.c+25 -140 replies
11/25clk: sunxi-ng: sun5i: Use local parent references for CLK_FIXED_FACTORdrivers/clk/sunxi-ng/ccu-sun5i.c+22 -120 replies
12/25clk: sunxi-ng: a31: Use local parent references for CLK_FIXED_FACTORdrivers/clk/sunxi-ng/ccu-sun6i-a31.c+25 -140 replies
13/25clk: sunxi-ng: a23: Use local parent references for CLK_FIXED_FACTORdrivers/clk/sunxi-ng/ccu-sun8i-a23.c+22 -120 replies
14/25clk: sunxi-ng: a33: Use local parent references for CLK_FIXED_FACTORdrivers/clk/sunxi-ng/ccu-sun8i-a33.c+22 -120 replies
15/25clk: sunxi-ng: h3: Use local parent references for CLK_FIXED_FACTORdrivers/clk/sunxi-ng/ccu-sun8i-h3.c+19 -100 replies
16/25clk: sunxi-ng: r40: Use local parent references for CLK_FIXED_FACTORdrivers/clk/sunxi-ng/ccu-sun8i-r40.c+29 -170 replies
17/25clk: sunxi-ng: v3s: Use local parent references for CLK_FIXED_FACTORdrivers/clk/sunxi-ng/ccu-sun8i-v3s.c+19 -100 replies
18/25clk: sunxi-ng: sun8i-r: Use local parent references for CLK_FIXED_FACTORdrivers/clk/sunxi-ng/ccu-sun8i-r.c+1 -10 replies
19/25clk: sunxi-ng: f1c100s: Use local parent references for CLK_FIXED_FACTORdrivers/clk/sunxi-ng/ccu-suniv-f1c100s.c+19 -100 replies
20/25clk: sunxi-ng: a64: Use local parent references for CLK_FIXED_FACTORdrivers/clk/sunxi-ng/ccu-sun50i-a64.c+26 -150 replies
21/25clk: sunxi-ng: h6: Use local parent references for CLK_FIXED_FACTORdrivers/clk/sunxi-ng/ccu-sun50i-h6.c+44 -250 replies
22/25clk: sunxi-ng: h6-r: Use local parent references for CLK_FIXED_FACTORdrivers/clk/sunxi-ng/ccu-sun50i-h6-r.c+1 -10 replies
23/25clk: sunxi-ng: gate: Add macros for referencing local clock parentsdrivers/clk/sunxi-ng/ccu_gate.h+53 -00 replies
24/25clk: sunxi-ng: a80-usb: Use local parent references for SUNXI_CCU_GATEdrivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c+20 -120 replies
25/25clk: sunxi-ng: sun8i-r: Use local parent references for SUNXI_CCU_GATEdrivers/clk/sunxi-ng/ccu-sun8i-r.c+23 -140 replies

Reviews trailers per patch

18 of 25 patches have a Reviewed-by or Acked-by.

PatchMaxime Ripard
1/25
2/25
3/25
4/25
5/25
6/25
7/25
8/25A-b
9/25A-b
10/25A-b
11/25A-b
12/25A-b
13/25A-b
14/25A-b
15/25A-b
16/25A-b
17/25A-b
18/25A-b
19/25A-b
20/25A-b
21/25A-b
22/25A-b
23/25A-b
24/25A-b
25/25A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/25] clk: sunxi-ng: clk parent rewrite part 1

From: Chen-Yu Tsai <[email protected]>

Hi everyone,

This is v2 of the sunxi-ng clk parent rewrite part 1.

Changes since v1:

- Collected Maxime's Acked-by for sunxi patches
- Expanded possible_parents_show() to cover most cases
- Added comment to CLK_HW_INIT_HWS detailing usage for sharing compound literal

As mentioned in my reply to the cover letter of v1, I can merge all the patches through the sunxi tree and send a combined (with other sunxi stuff) PR, or as an independent branch, whichever is preferred.

Excerpt from original cover letter follows:

This is series is the first part of a large series (I haven't done the rest) of patches to rewrite the clk parent relationship handling within the sunxi-ng clk driver. This is based on Stephen's recent work allowing clk drivers to specify clk parents using struct clk_hw * or parsing DT phandles in the clk node.

This series can be split into a few major parts:

1) The first patch is a small fix for clk debugfs representation. This was done before commit 1a079560b145 ("clk: Cache core in clk_fetch_parent_index() without names") was posted, so it might or might not be needed. Found this when checking my work using clk_possible_parents.

2) A bunch of CLK_HW_INIT_* helper macros are added. These cover the situations I encountered, or assume I will encounter, such as single internal (struct clk_hw *) parent, single DT (struct clk_parent_data .fw_name), multiple internal parents, and multiple mixed (internal + DT) parents. A special variant for just an internal single parent is added, CLK_HW_INIT_HWS, which lets the driver share the singular list, instead of having the compiler create a compound literal every time. It might even make sense to only keep this variant.

3) A bunch of CLK_FIXED_FACTOR_* helper macros are added. The rationale is the same as the single parent CLK_HW_INIT_* helpers.

4) Bulk conversion of CLK_FIXED_FACTOR to use local parent references, either struct clk_hw * or DT .fw_name types, whichever the hardware requires.

5) The beginning of SUNXI_CCU_GATE conversion to local parent references. This part is not done. They are included as justification and examples for the shared list of clk parents case.

Thanks
ChenYu

Chen-Yu Tsai (25):
clk: Fix debugfs clk_possible_parents for clks without parent string
names
clk: Add CLK_HW_INIT_* macros using .parent_hws
clk: Add CLK_HW_INIT_FW_NAME macro using .fw_name in .parent_data
clk: Add CLK_HW_INIT_PARENT_DATA macro using .parent_data
clk: fixed-factor: Add CLK_FIXED_FACTOR_HW which takes clk_hw pointer
as parent
clk: fixed-factor: Add CLK_FIXED_FACTOR_HWS which takes list of struct
clk_hw *
clk: fixed-factor: Add CLK_FIXED_FACTOR_FW_NAME for DT clock-names
parent
clk: sunxi-ng: switch to of_clk_hw_register() for registering clks
clk: sunxi-ng: sun8i-r: Use local parent references for CLK_HW_INIT_*
clk: sunxi-ng: a10: Use local parent references for CLK_FIXED_FACTOR
clk: sunxi-ng: sun5i: Use local parent references for CLK_FIXED_FACTOR
clk: sunxi-ng: a31: Use local parent references for CLK_FIXED_FACTOR
clk: sunxi-ng: a23: Use local parent references for CLK_FIXED_FACTOR
clk: sunxi-ng: a33: Use local parent references for CLK_FIXED_FACTOR
clk: sunxi-ng: h3: Use local parent references for CLK_FIXED_FACTOR
clk: sunxi-ng: r40: Use local parent references for CLK_FIXED_FACTOR
clk: sunxi-ng: v3s: Use local parent references for CLK_FIXED_FACTOR
clk: sunxi-ng: sun8i-r: Use local parent references for
CLK_FIXED_FACTOR
clk: sunxi-ng: f1c100s: Use local parent references for
CLK_FIXED_FACTOR
clk: sunxi-ng: a64: Use local parent references for CLK_FIXED_FACTOR
clk: sunxi-ng: h6: Use local parent references for CLK_FIXED_FACTOR
clk: sunxi-ng: h6-r: Use local parent references for CLK_FIXED_FACTOR
clk: sunxi-ng: gate: Add macros for referencing local clock parents
clk: sunxi-ng: a80-usb: Use local parent references for SUNXI_CCU_GATE
clk: sunxi-ng: sun8i-r: Use local parent references for SUNXI_CCU_GATE

 drivers/clk/clk.c                        |  44 +++++++++-
 drivers/clk/sunxi-ng/ccu-sun4i-a10.c     |  39 ++++++---
 drivers/clk/sunxi-ng/ccu-sun50i-a64.c    |  41 +++++----
 drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c   |   2 +-
 drivers/clk/sunxi-ng/ccu-sun50i-h6.c     |  69 +++++++++------
 drivers/clk/sunxi-ng/ccu-sun5i.c         |  34 +++++---
 drivers/clk/sunxi-ng/ccu-sun6i-a31.c     |  39 ++++++---
 drivers/clk/sunxi-ng/ccu-sun8i-a23.c     |  34 +++++---
 drivers/clk/sunxi-ng/ccu-sun8i-a33.c     |  34 +++++---
 drivers/clk/sunxi-ng/ccu-sun8i-h3.c      |  29 ++++---
 drivers/clk/sunxi-ng/ccu-sun8i-r.c       | 104 +++++++++++------------
 drivers/clk/sunxi-ng/ccu-sun8i-r40.c     |  46 ++++++----
 drivers/clk/sunxi-ng/ccu-sun8i-v3s.c     |  29 ++++---
 drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c |  32 ++++---
 drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c |  29 ++++---
 drivers/clk/sunxi-ng/ccu_common.c        |   2 +-
 drivers/clk/sunxi-ng/ccu_gate.h          |  53 ++++++++++++
 include/linux/clk-provider.h             |  89 +++++++++++++++++++
 18 files changed, 526 insertions(+), 223 deletions(-)
Signature · 7 lines
2.20.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel