Skip to content

I2C IRQ Probe Improvements

Charles Keepax linux-acpi linux-i2c lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5i2c: acpi: Factor out getting the IRQ from ACPIdrivers/i2c/i2c-core-acpi.c+25 -151 reply
2/5i2c: acpi: Use available IRQ helper functionsdrivers/i2c/i2c-core-acpi.c drivers/i2c/i2c-core-base.c drivers/i2c/i2c-core.h+18 -110 replies
3/5i2c: core: Move ACPI IRQ handling to probe timedrivers/i2c/i2c-core-acpi.c drivers/i2c/i2c-core-base.c drivers/i2c/i2c-core.h+14 -54 replies
4/5i2c: core: Move ACPI gpio IRQ handling into i2c_acpi_get_irqdrivers/i2c/i2c-core-acpi.c drivers/i2c/i2c-core-base.c+3 -41 reply
5/5i2c: core: Tidy up handling of init_irqdrivers/i2c/i2c-core-base.c+3 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] I2C IRQ Probe Improvements

This series attempts to align as much IRQ handling into the probe path as possible. Note that I don't have a great setup for testing these patches so they are mostly just build tested and need careful review and testing before any of them are merged.

The series brings the ACPI path inline with the way the device tree path handles the IRQ entirely at probe time. However, it still leaves any IRQ specified through the board_info as being handled at device time. In that case we need to cache something from the board_info until probe time, which leaves any alternative solution with something basically the same as the current handling although perhaps caching more stuff.

Thanks,
Charles

See previous discussions:
- https://lkml.org/lkml/2019/2/15/989
- https://www.spinics.net/lists/linux-i2c/msg39541.html

Charles Keepax (5):
i2c: acpi: Factor out getting the IRQ from ACPI
i2c: acpi: Use available IRQ helper functions
i2c: core: Move ACPI IRQ handling to probe time
i2c: core: Move ACPI gpio IRQ handling into i2c_acpi_get_irq
i2c: core: Tidy up handling of init_irq

 drivers/i2c/i2c-core-acpi.c | 50 ++++++++++++++++++++++++++++++---------------
 drivers/i2c/i2c-core-base.c | 11 +++++-----
 drivers/i2c/i2c-core.h      |  9 ++++++++
 3 files changed, 48 insertions(+), 22 deletions(-)
Signature · 1 line
2.11.0