RFC Fix return value checks for posix apis
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest1 patch 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | open_posix_testsuite/pthread_sigmask: fix return value checks | +0 | 1 reply | |
| 1/1 | open_posix_testsuite/pthread_sigmask: fix return value checks | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [LTP] [RFC PATCH 0/1] Fix return value checks for posix apis
Hi!
Quoted 4 lines
This is an RFC patch to demonstrate that most of the pthread_* calls in the
open_posix_testsuiteseem to be doing the return value checks incorrectly. Most posix_* apis return positive errno on failure and 0 on success.
This is unfortunately common misconception, also I guess you meant pthread_* APIs here.
Quoted 11 lines
PATCH 1/1 demonstrates the fixes needed for pthread_sigmask/6-1 for example. This pattern is fairly widespread in
open_posix_testsuite.After going through the documentation in the project, I wasn't sure if I tested this correctly. After building, I tried the following
$ cd testcases/open_posix_testsuite $ ./bin/run_tesit.sh conformance/interfaces/pthread_sigmask pthread_sigmask_6-1.run-test...and that keeps running into test being skipped due to missing file. (I do have pthread_sigmask_6-1.run-test in place).
Actually I always just run the binary, so in this case doing ./pthread_sigmask_6-1.run-test should suffice.
Quoted 3 lines
So, consider this build tested only for now. I'd love to know how we can test this and if we are still using the testsuite, then I am happy to fix rest of the places where its broken.
Sounds good.
Signature · 2 lines
Cyril Hrubis [email protected]