net: introduce "include/linux/if_rmnet.h"
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest8 patches 15 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | net: qualcomm: rmnet: fix struct rmnet_map_headerdrivers/ | +2 | 7 replies | |
| 2/8 | net: qualcomm: rmnet: kill RMNET_MAP_GET_*() accessor macrosdrivers/ drivers/ drivers/ +1 more | +15 | 1 reply | |
| 3/8 | net: qualcomm: rmnet: use field masks instead of C bit-fieldsdrivers/ drivers/ drivers/ | +12 | 1 reply | |
| 4/8 | net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum headerdrivers/ drivers/ | +26 | 1 reply | |
| 5/8 | net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum trailerdrivers/ drivers/ | +5 | 1 reply | |
| 6/8 | net: qualcomm: rmnet: get rid of a variable in rmnet_map_ipv4_ul_csum_header()drivers/ | +4 | 1 reply | |
| 7/8 | net: qualcomm: rmnet: mark endianness of struct rmnet_map_dl_csum_trailer fieldsdrivers/ | +2 | 1 reply | |
| 8/8 | net: introduce "include/linux/if_rmnet.h"drivers/ drivers/ drivers/ +3 more | +49 | 1 reply |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Bjorn Andersson |
|---|---|
| 1/8 | R-b |
| 2/8 | R-b |
| 3/8 | R-b |
| 4/8 | R-b |
| 5/8 | R-b |
| 6/8 | R-b |
| 7/8 | R-b |
| 8/8 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/8] net: introduce "include/linux/if_rmnet.h"
The main objective of this series was originally to define a single public header file containing a few structure definitions that are currently defined privately for the Qualcomm "rmnet" driver. In review, Arnd Bergmann said that before making them public, the structures should avoid using C bit-fields in their definitions.
To facilitate implementing that suggestion I rearranged some other code, including eliminating some accessor macros that I believe reduce rather than improve the clarity of the code that uses them.
I also discovered a bug (concievably due to non-portable behavior) in the way one of the structures is defined, so I fixed that. And finally I ensured all of the fields in these structures were defined with proper annotation of their big endianness.
A form of the code in this series was present in this patch:
https://lore.kernel.org/lkml/[email protected]/
This series is available here, based on kernel v5.2-rc1:
remote: https://git.linaro.org/people/elder/linux.git
branch: ipa-rmnet-v1_kernel-5.2-rc1
acbcb18302a net: introduce "include/linux/if_rmnet.h"
-Alex
Alex Elder (8):
net: qualcomm: rmnet: fix struct rmnet_map_header
net: qualcomm: rmnet: kill RMNET_MAP_GET_*() accessor macros
net: qualcomm: rmnet: use field masks instead of C bit-fields
net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum header
net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum trailer
net: qualcomm: rmnet: get rid of a variable in
rmnet_map_ipv4_ul_csum_header()
net: qualcomm: rmnet: mark endianness of struct
rmnet_map_dl_csum_trailer fields
net: introduce "include/linux/if_rmnet.h"
.../ethernet/qualcomm/rmnet/rmnet_handlers.c | 11 ++-- .../net/ethernet/qualcomm/rmnet/rmnet_map.h | 36 ---------- .../qualcomm/rmnet/rmnet_map_command.c | 12 +++- .../ethernet/qualcomm/rmnet/rmnet_map_data.c | 65 +++++++++---------- .../net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 1 + include/linux/if_rmnet.h | 45 +++++++++++++ 6 files changed, 91 insertions(+), 79 deletions(-) create mode 100644 include/linux/if_rmnet.h
Signature · 1 line
2.20.1