Skip to content

spapr: Do not re-read the clock on pre_save handler on migration

Maxiwell S. Garcia qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1spapr: Do not re-read the clock on pre_save handler on migrationhw/ppc/ppc.c+0 -245 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/1] spapr: Do not re-read the clock on pre_save handler on migration

I suggest to remove the pre_save handler that saves the timebase before migrate. The commit that added this was ported from x86:
6053a86fe7bd: kvmclock: reduce kvmclock difference on migration

The review [1] had a discussion about it. The author says that a VM already paused 10 minutes ago should re-read the clock just before migrate. But a reviewer question was not answered:

"Is it really valid to make the clock move on an already-paused VM, only because it was migrated?"

This clock move makes the guest know about the pause between the stop and migrate commands. Many side effects could happen after migration.

[1] http://lists.nongnu.org/archive/html/qemu-devel/2016-12/msg00610.html

Maxiwell S. Garcia (1):
spapr: Do not re-read the clock on pre_save handler on migration

 hw/ppc/ppc.c | 24 ------------------------
 1 file changed, 24 deletions(-)
Signature · 1 line
2.20.1