fw_cfg_test refactor and add two test cases
Get series with b4
b4 am [email protected]Versions newest first
- v3 Latest7 patches 3 repliesIn review
Changes in v3 from the cover letter
- split 1st patch
- clarified commit description based on review comments on list
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | tests/libqos: Add io_fw_cfg_uninit() and mm_fw_cfg_uninit()tests/ tests/ | +12 | 1 reply | |
| 2/7 | tests/libqos: Add pc_fw_cfg_uninit() and use ittests/ tests/ tests/ | +7 | 1 reply | |
| 3/7 | tests: refactor fw_cfg_testtests/ | +78 | 0 replies | |
| 4/7 | tests: fw_cfg: add a function to get the fw_cfg filetests/ tests/ | +47 | 0 replies | |
| 5/7 | hw/nvram/fw_cfg: Store 'reboot-timeout' as little endianhw/ | +3 | 0 replies | |
| 6/7 | tests: fw_cfg: add 'reboot-timeout' test casetests/ | +21 | 0 replies | |
| 7/7 | tests: fw_cfg: add 'splash-time' test casetests/ | +20 | 0 replies |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Thomas Huth | Philippe Mathieu-Daudé | Laszlo Ersek |
|---|---|---|---|
| 1/7 | T-b | R-b T-b | R-b |
| 2/7 | T-b | R-b T-b | R-b |
| 3/7 | A-b T-b | R-b T-b | |
| 4/7 | A-b T-b | R-b T-b | |
| 5/7 | T-b | R-b T-b | |
| 6/7 | T-b | R-b T-b | |
| 7/7 | T-b | R-b T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [Qemu-devel] [PATCH v3 0/7] fw_cfg_test refactor and add two test cases
This is the work from Li Qiang, I added few changes while preparing the pull request. If Li is OK with it, I'll send as it.
Since v2:
- split 1st patch
- clarified commit description based on review comments on list
Since v1:
- Add a patch to store the reboot_timeout as little endian
v2: https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg04064.html
v1: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg05679.html
Li Qiang (5):
tests: refactor fw_cfg_test
tests: fw_cfg: add a function to get the fw_cfg file hw/nvram/fw_cfg: Store 'reboot-timeout' as little endian
tests: fw_cfg: add 'reboot-timeout' test case
tests: fw_cfg: add 'splash-time' test case
Philippe Mathieu-Daudé (2):
tests/libqos: Add io_fw_cfg_uninit() and mm_fw_cfg_uninit() tests/libqos: Add pc_fw_cfg_uninit() and use it
hw/nvram/fw_cfg.c | 4 +- tests/fw_cfg-test.c | 127 +++++++++++++++++++++++++++++++++++---- tests/libqos/fw_cfg.c | 55 +++++++++++++++++ tests/libqos/fw_cfg.h | 9 +++ tests/libqos/malloc-pc.c | 2 +- 5 files changed, 184 insertions(+), 13 deletions(-)
Signature · 1 line
2.20.1