Skip to content

fw_cfg_test refactor and add two test cases

Philippe Mathieu-Daudé qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest7 patches 3 repliesIn review

Changes in v3 from the cover letter

- split 1st patch
- clarified commit description based on review comments on list

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7tests/libqos: Add io_fw_cfg_uninit() and mm_fw_cfg_uninit()tests/libqos/fw_cfg.c tests/libqos/fw_cfg.h+12 -01 reply
2/7tests/libqos: Add pc_fw_cfg_uninit() and use ittests/fw_cfg-test.c tests/libqos/fw_cfg.h tests/libqos/malloc-pc.c+7 -11 reply
3/7tests: refactor fw_cfg_testtests/fw_cfg-test.c+78 -150 replies
4/7tests: fw_cfg: add a function to get the fw_cfg filetests/libqos/fw_cfg.c tests/libqos/fw_cfg.h+47 -00 replies
5/7hw/nvram/fw_cfg: Store 'reboot-timeout' as little endianhw/nvram/fw_cfg.c+3 -10 replies
6/7tests: fw_cfg: add 'reboot-timeout' test casetests/fw_cfg-test.c+21 -00 replies
7/7tests: fw_cfg: add 'splash-time' test casetests/fw_cfg-test.c+20 -00 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchThomas HuthPhilippe Mathieu-DaudéLaszlo Ersek
1/7T-b R-b T-b R-b
2/7T-b R-b T-b R-b
3/7A-b T-b R-b T-b
4/7A-b T-b R-b T-b
5/7T-b R-b T-b
6/7T-b R-b T-b
7/7T-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/7] fw_cfg_test refactor and add two test cases

This is the work from Li Qiang, I added few changes while preparing the pull request. If Li is OK with it, I'll send as it.

Since v2:
- split 1st patch
- clarified commit description based on review comments on list

Since v1:
- Add a patch to store the reboot_timeout as little endian

v2: https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg04064.html
v1: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg05679.html

Li Qiang (5):
tests: refactor fw_cfg_test
tests: fw_cfg: add a function to get the fw_cfg file hw/nvram/fw_cfg: Store 'reboot-timeout' as little endian
tests: fw_cfg: add 'reboot-timeout' test case
tests: fw_cfg: add 'splash-time' test case

Philippe Mathieu-Daudé (2):
tests/libqos: Add io_fw_cfg_uninit() and mm_fw_cfg_uninit() tests/libqos: Add pc_fw_cfg_uninit() and use it

 hw/nvram/fw_cfg.c        |   4 +-
 tests/fw_cfg-test.c      | 127 +++++++++++++++++++++++++++++++++++----
 tests/libqos/fw_cfg.c    |  55 +++++++++++++++++
 tests/libqos/fw_cfg.h    |   9 +++
 tests/libqos/malloc-pc.c |   2 +-
 5 files changed, 184 insertions(+), 13 deletions(-)
Signature · 1 line
2.20.1